Skip to content

Incorrect CreateNewUser Action Stub Being Published #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmillis1 opened this issue Sep 12, 2020 · 0 comments
Closed

Incorrect CreateNewUser Action Stub Being Published #30

mmillis1 opened this issue Sep 12, 2020 · 0 comments

Comments

@mmillis1
Copy link

mmillis1 commented Sep 12, 2020

  • Fortify Version: 1.3.1
  • Laravel Version: 8.1.0
  • PHP Version: 7.4.9
  • Database Driver & Version: MySQL

Description:

When running The laravel installer or jetstream install command, the CreateNewUser Fortify Action generated does not match the stub within the fortify project.

For example. within the fortify package the CreateNewUser Fortify Action uses the proper PasswordValidationRules trait for the password validator. When that stub is published to my project, the CreateNewUser Action does not use the PasswordValidationRules trait and instead has 'password' => ['required', 'string', new Password, 'confirmed'],

I've tried removing any composer cache but it continues to happen.

``

Steps To Reproduce:

laravel new laravel8-jet --jet

Select inertia, and no teams

OR

laravel new laravel8-jet
composer require laravel/jetstream
php artisan jetstream:install

Now view the laravel8-jet/app/Actions/Fortify/CreateNewUser file and compare to the package's stub version.

I've also attached a screenshot:
Screenshot from 2020-09-12 14-03-33

EDIT: This actually looks like it may be a jetstream problem as the CreateNewUser stub within that package looks out of date with Fortify. I will keep this here just in case you decide to keep this open and I'm incorrect but it looks like it's unrelated to this project. Opening a ticket in the jetstream repo: laravel/jetstream#167 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant