[11.x] Fix serve command with PHP_CLI_SERVER_WORKERS (#54606)

* Fixes `serve` command with `PHP_CLI_SERVER_WORKERS`

By default, serve command would restart child process when there's
modification to the `.env` file. However, with `PHP_CLI_SERVER_WORKERS`
set to larger than 1 the process doesn't close properly (port is still
being used) and this cause the restart process to pick an incremented
port number.

The changes here will unset `PHP_CLI_SERVER_WORKERS` value unless the
command is executed with `--no-reload` option.

fixes #54574

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* Apply fixes from StyleCI

* Update src/Illuminate/Foundation/Console/ServeCommand.php

* Update src/Illuminate/Foundation/Console/ServeCommand.php

* Update ServeCommand.php

* Update ServeCommand.php

---------

Signed-off-by: Mior Muhammad Zaki <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Illuminate/Foundation/Console/ServeCommand.php

@@ -9,7 +9,9 @@
 use Illuminate\Support\InteractsWithTime;
 use Illuminate\Support\Stringable;
 use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Process\Process;
 
 use function Illuminate\Support\php_binary;
@@ -34,6 +36,13 @@ class ServeCommand extends Command
      */
     protected $description = 'Serve the application on the PHP development server';
 
+    /**
+     * The number of PHP CLI server workers.
+     *
+     * @var int<2, max>|false
+     */
+    protected $phpServerWorkers = 1;
+
     /**
      * The current port offset.
      *
@@ -76,14 +85,28 @@ class ServeCommand extends Command
         'IGNITION_LOCAL_SITES_PATH',
         'LARAVEL_SAIL',
         'PATH',
-        'PHP_CLI_SERVER_WORKERS',
         'PHP_IDE_CONFIG',
         'SYSTEMROOT',
         'XDEBUG_CONFIG',
         'XDEBUG_MODE',
         'XDEBUG_SESSION',
     ];
 
+    /** {@inheritdoc} */
+    #[\Override]
+    protected function initialize(InputInterface $input, OutputInterface $output)
+    {
+        $this->phpServerWorkers = transform(env('PHP_CLI_SERVER_WORKERS', 1), function ($workers) {
+            if (! is_int($workers) || $workers < 2) {
+                return false;
+            }
+
+            return $workers > 1 && ! $this->option('no-reload') ? false : $workers;
+        });
+
+        parent::initialize($input, $output);
+    }
+
     /**
      * Execute the console command.
      *
@@ -154,7 +177,7 @@ protected function startProcess($hasEnvironment)
             }
 
             return in_array($key, static::$passthroughVariables) ? [$key => $value] : [$key => false];
-        })->all());
+        })->merge(['PHP_CLI_SERVER_WORKERS' => $this->phpServerWorkers])->all());
 
         $this->trap(fn () => [SIGTERM, SIGINT, SIGHUP, SIGUSR1, SIGUSR2, SIGQUIT], function ($signal) use ($process) {
             if ($process->isRunning()) {
@@ -360,7 +383,7 @@ protected function flushOutputBuffer()
      */
     protected function getDateFromLine($line)
     {
-        $regex = ! windows_os() && env('PHP_CLI_SERVER_WORKERS', 1) > 1
+        $regex = ! windows_os() && is_int($this->phpServerWorkers)
             ? '/^\[\d+]\s\[([a-zA-Z0-9: ]+)\]/'
             : '/^\[([^\]]+)\]/';