Inconsistent parameter naming between Storage::fake temporary URLs (expiration) and signed routes (expires)

[moessimple]

Hi everyone,

I noticed an inconsistency between how temporary signed URLs are generated when using Storage::fake() in tests versus how they are built in production using Storage::temporaryUrl() or URL::signedRoute().

In tests (Storage::fake())

When faking a disk and building a temporary URL, the parameter expiration is used:

Storage::fake()->buildTemporaryUrlsUsing(function ($path, $expiration) {
    return URL::to($path.'?expiration='.$expiration->getTimestamp());
});

In production (URL::signedRoute())

However, the signedRoute() method adds the expiration using the expires parameter:

if ($expiration) {
    $parameters = $parameters + ['expires' => $this->availableAt($expiration)];
}

This means that in tests, URLs will contain expiration=..., while in production, they contain expires=

Is this difference in parameter naming intentional?
Thanks in advance