Failed Job in Chained Batch, doesn't call Finally closure

[wit3]

• Laravel Version: 8.64.0
• PHP Version: 8.0.10
• Database Driver & Version: PostgreSQL, 10.11

Description:

Hi, if i distpach a simple chained batch like this : chains-within-batches

Bus::batch([
    [
        new ReleasePodcast(1),
        new SendPodcastReleaseNotification(1),
    ],
    [
        new ReleasePodcast(2),
        new SendPodcastReleaseNotification(2),
    ],
])
->finally(function (Batch $batch) {
    // The batch has finished executing...
})
->then(function (Batch $batch) {
    // ...
})->dispatch();

If any of thes chained job fail, the closure defined doesn't trigger, it's a bug?

Steps To Reproduce:

[driesvints]

See #36076

[taylorotwell]

This is a slightly different issue than #36076

I can see the reasoning behind the current behavior to some extent - the "finally" callback executes when all of the jobs in the batch have fun exactly once (success or failure - doesn't matter)... in the case of your chain, the jobs after the failing job have not executed at all, so finally is never firing. It isn't firing because "pending jobs" - "failed jobs" does not equal 0.

This is because when you add a chain to a batch we increment pending jobs for the number of jobs in the chain.