Skip to content

Commit b8c0786

Browse files
committed
Merge branch '2.x'
# Conflicts: # CHANGELOG.md # stubs/livewire/resources/views/auth/forgot-password.blade.php # stubs/livewire/resources/views/auth/login.blade.php # stubs/livewire/resources/views/auth/register.blade.php # stubs/livewire/resources/views/auth/reset-password.blade.php # stubs/livewire/resources/views/components/confirms-password.blade.php # stubs/livewire/resources/views/profile/delete-user-form.blade.php # stubs/livewire/resources/views/profile/logout-other-browser-sessions-form.blade.php # stubs/livewire/resources/views/profile/update-profile-information-form.blade.php
2 parents a365b6b + adf42f0 commit b8c0786

19 files changed

+60
-13
lines changed

.github/workflows/tests.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
composer update --prefer-dist --no-interaction --no-progress
4444
4545
- name: Execute tests
46-
run: vendor/bin/phpunit --verbose
46+
run: vendor/bin/phpunit
4747

4848
stub-tests:
4949
runs-on: ubuntu-22.04
@@ -79,7 +79,7 @@ jobs:
7979
- name: Install Jetstream
8080
run: |
8181
composer update "laravel/jetstream" --prefer-dist --no-interaction --no-progress -W
82-
php artisan jetstream:install ${{ matrix.stack }} --teams --api --verification
82+
php artisan jetstream:install ${{ matrix.stack }} --teams --api --verification --pest
8383
8484
- name: Install NPM dependencies
8585
run: npm i
@@ -88,7 +88,7 @@ jobs:
8888
run: npm run build
8989

9090
- name: Execute tests
91-
run: vendor/bin/phpunit --verbose
91+
run: vendor/bin/pest
9292
env:
9393
DB_CONNECTION: sqlite
9494
DB_DATABASE: ":memory:"

CHANGELOG.md

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
# Release Notes
22

3-
## [Unreleased](https://github.com/laravel/jetstream/compare/v2.16.0...master)
3+
## [Unreleased](https://github.com/laravel/jetstream/compare/v2.16.1...master)
4+
5+
## [v2.16.1](https://github.com/laravel/jetstream/compare/v2.16.0...v2.16.1) - 2023-02-03
6+
7+
### Fixed
8+
9+
- Fix typo by @nhedger in https://github.com/laravel/jetstream/pull/1230
10+
- Fixed not redirecting after deleting the user by @JakyeRU in https://github.com/laravel/jetstream/pull/1236
11+
- Use autocomplete for all fields for password manager compatibility by @lukearmstrong in https://github.com/laravel/jetstream/pull/1239
12+
- Fixes Pest stubs files by @nunomaduro in https://github.com/laravel/jetstream/pull/1240
413

514
## [v2.16.0](https://github.com/laravel/jetstream/compare/v2.15.0...v2.16.0) - 2023-01-18
615

src/Console/InstallCommand.php

+31-3
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,9 @@ public function handle()
101101
$stubs = $this->getTestStubsPath();
102102

103103
if ($this->option('pest')) {
104-
if ($this->requireComposerDevPackages('pestphp/pest:^1.16', 'pestphp/pest-plugin-laravel:^1.1')) {
104+
$this->removeComposerDevPackages(['nunomaduro/collision', 'phpunit/phpunit']);
105+
106+
if (! $this->requireComposerDevPackages(['nunomaduro/collision:^6.4', 'pestphp/pest:^1.22', 'pestphp/pest-plugin-laravel:^1.2'])) {
105107
return 1;
106108
}
107109

@@ -670,6 +672,32 @@ protected function requireComposerPackages($packages)
670672
});
671673
}
672674

675+
/**
676+
* Removes the given Composer Packages as "dev" dependencies.
677+
*
678+
* @param mixed $packages
679+
* @return bool
680+
*/
681+
protected function removeComposerDevPackages($packages)
682+
{
683+
$composer = $this->option('composer');
684+
685+
if ($composer !== 'global') {
686+
$command = [$this->phpBinary(), $composer, 'remove', '--dev'];
687+
}
688+
689+
$command = array_merge(
690+
$command ?? ['composer', 'remove', '--dev'],
691+
is_array($packages) ? $packages : func_get_args()
692+
);
693+
694+
return (new Process($command, base_path(), ['COMPOSER_MEMORY_LIMIT' => '-1']))
695+
->setTimeout(null)
696+
->run(function ($type, $output) {
697+
$this->output->write($output);
698+
}) === 0;
699+
}
700+
673701
/**
674702
* Install the given Composer Packages as "dev" dependencies.
675703
*
@@ -689,11 +717,11 @@ protected function requireComposerDevPackages($packages)
689717
is_array($packages) ? $packages : func_get_args()
690718
);
691719

692-
return ! (new Process($command, base_path(), ['COMPOSER_MEMORY_LIMIT' => '-1']))
720+
return (new Process($command, base_path(), ['COMPOSER_MEMORY_LIMIT' => '-1']))
693721
->setTimeout(null)
694722
->run(function ($type, $output) {
695723
$this->output->write($output);
696-
});
724+
}) === 0;
697725
}
698726

699727
/**

stubs/inertia/resources/js/Components/ConfirmsPassword.vue

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ const closeModal = () => {
9191
type="password"
9292
class="mt-1 block w-3/4"
9393
placeholder="Password"
94+
autocomplete="current-password"
9495
@keyup.enter="confirmPassword"
9596
/>
9697

stubs/inertia/resources/js/Pages/Auth/ForgotPassword.vue

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ const submit = () => {
4646
class="mt-1 block w-full"
4747
required
4848
autofocus
49+
autocomplete="username"
4950
/>
5051
<InputError class="mt-2" :message="form.errors.email" />
5152
</div>

stubs/inertia/resources/js/Pages/Auth/Login.vue

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ const submit = () => {
5151
class="mt-1 block w-full"
5252
required
5353
autofocus
54+
autocomplete="username"
5455
/>
5556
<InputError class="mt-2" :message="form.errors.email" />
5657
</div>

stubs/inertia/resources/js/Pages/Auth/Register.vue

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const submit = () => {
5454
type="email"
5555
class="mt-1 block w-full"
5656
required
57+
autocomplete="username"
5758
/>
5859
<InputError class="mt-2" :message="form.errors.email" />
5960
</div>

stubs/inertia/resources/js/Pages/Auth/ResetPassword.vue

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const submit = () => {
4444
class="mt-1 block w-full"
4545
required
4646
autofocus
47+
autocomplete="username"
4748
/>
4849
<InputError class="mt-2" :message="form.errors.email" />
4950
</div>

stubs/inertia/resources/js/Pages/Profile/Partials/DeleteUserForm.vue

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ const closeModal = () => {
7474
type="password"
7575
class="mt-1 block w-3/4"
7676
placeholder="Password"
77+
autocomplete="current-password"
7778
@keyup.enter="deleteUser"
7879
/>
7980

stubs/inertia/resources/js/Pages/Profile/Partials/LogoutOtherBrowserSessionsForm.vue

+1
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ const closeModal = () => {
113113
type="password"
114114
class="mt-1 block w-3/4"
115115
placeholder="Password"
116+
autocomplete="current-password"
116117
@keyup.enter="logoutOtherBrowserSessions"
117118
/>
118119

stubs/inertia/resources/js/Pages/Profile/Partials/UpdateProfileInformationForm.vue

+1
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ const clearPhotoFileInput = () => {
148148
v-model="form.email"
149149
type="email"
150150
class="mt-1 block w-full"
151+
autocomplete="username"
151152
/>
152153
<InputError :message="form.errors.email" class="mt-2" />
153154

stubs/livewire/resources/views/auth/forgot-password.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
<div class="block">
2323
<x-label for="email" value="{{ __('Email') }}" />
24-
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required autofocus />
24+
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required autofocus autocomplete="username" />
2525
</div>
2626

2727
<div class="flex items-center justify-end mt-4">

stubs/livewire/resources/views/auth/login.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<div>
1919
<x-label for="email" value="{{ __('Email') }}" />
20-
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required autofocus />
20+
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required autofocus autocomplete="username" />
2121
</div>
2222

2323
<div class="mt-4">

stubs/livewire/resources/views/auth/register.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
<div class="mt-4">
1818
<x-label for="email" value="{{ __('Email') }}" />
19-
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required />
19+
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email')" required autocomplete="username" />
2020
</div>
2121

2222
<div class="mt-4">

stubs/livewire/resources/views/auth/reset-password.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<div class="block">
1515
<x-label for="email" value="{{ __('Email') }}" />
16-
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email', $request->email)" required autofocus />
16+
<x-input id="email" class="block mt-1 w-full" type="email" name="email" :value="old('email', $request->email)" required autofocus autocomplete="username" />
1717
</div>
1818

1919
<div class="mt-4">

stubs/livewire/resources/views/components/confirms-password.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
{{ $content }}
2525

2626
<div class="mt-4" x-data="{}" x-on:confirming-password.window="setTimeout(() => $refs.confirmable_password.focus(), 250)">
27-
<x-input type="password" class="mt-1 block w-3/4" placeholder="{{ __('Password') }}"
27+
<x-input type="password" class="mt-1 block w-3/4" placeholder="{{ __('Password') }}" autocomplete="current-password"
2828
x-ref="confirmable_password"
2929
wire:model.defer="confirmablePassword"
3030
wire:keydown.enter="confirmPassword" />

stubs/livewire/resources/views/profile/delete-user-form.blade.php

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
<div class="mt-4" x-data="{}" x-on:confirming-delete-user.window="setTimeout(() => $refs.password.focus(), 250)">
3131
<x-input type="password" class="mt-1 block w-3/4"
32+
autocomplete="current-password"
3233
placeholder="{{ __('Password') }}"
3334
x-ref="password"
3435
wire:model.defer="password"

stubs/livewire/resources/views/profile/logout-other-browser-sessions-form.blade.php

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272

7373
<div class="mt-4" x-data="{}" x-on:confirming-logout-other-browser-sessions.window="setTimeout(() => $refs.password.focus(), 250)">
7474
<x-input type="password" class="mt-1 block w-3/4"
75+
autocomplete="current-password"
7576
placeholder="{{ __('Password') }}"
7677
x-ref="password"
7778
wire:model.defer="password"

stubs/livewire/resources/views/profile/update-profile-information-form.blade.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<!-- Email -->
6363
<div class="col-span-6 sm:col-span-4">
6464
<x-label for="email" value="{{ __('Email') }}" />
65-
<x-input id="email" type="email" class="mt-1 block w-full" wire:model.defer="state.email" />
65+
<x-input id="email" type="email" class="mt-1 block w-full" wire:model.defer="state.email" autocomplete="username" />
6666
<x-input-error for="email" class="mt-2" />
6767

6868
@if (Laravel\Fortify\Features::enabled(Laravel\Fortify\Features::emailVerification()) && ! $this->user->hasVerifiedEmail())

0 commit comments

Comments
 (0)