Skip to content

SDXL Clip doesn't get quantized and is set to FP32 #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmatif opened this issue Feb 27, 2025 · 3 comments · Fixed by #607
Closed

SDXL Clip doesn't get quantized and is set to FP32 #605

rmatif opened this issue Feb 27, 2025 · 3 comments · Fixed by #607

Comments

@rmatif
Copy link

rmatif commented Feb 27, 2025

I've noticed that with the release master-9578fdc , and specifically with this commit, the ability to quantize CLIP on SDXL models has been removed, causing it to always load as FP32. And it's still the case in the current release

log 9578fdc

log_9578fdc.txt

log b5f4932 (the just previous release)

log_b5f4932.txt

I'm wondering if this change was intentional. If not, I'm surprised that no one has noticed it yet

@stduhpf
Copy link
Contributor

stduhpf commented Feb 28, 2025

That's definitely not intentional. Only the VAE is supposed to be forced as f32 for SDXL. I'll look into it.

@rmatif
Copy link
Author

rmatif commented Feb 28, 2025

@stduhpf Thanks for taking a look!

@stduhpf
Copy link
Contributor

stduhpf commented Feb 28, 2025

Interesting, it seems to only be happening when using a .safetensors file. With a .gguf, the clip models are quantized as expected, which might explain why it got unnoticed before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants