Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gitlab-registry): added minor major and channel tags #2

Merged
merged 12 commits into from
Apr 8, 2020
Merged

feat(gitlab-registry): added minor major and channel tags #2

merged 12 commits into from
Apr 8, 2020

Conversation

L-U-C-K-Y
Copy link

@L-U-C-K-Y L-U-C-K-Y commented Apr 6, 2020 •
edited
Loading

Pending:

  • I assume "name" in config is not required?
  • Requires review and testing

@commit-lint
Copy link

commit-lint bot commented Apr 6, 2020 •
edited
Loading

Features

  • gitlab-registry: added minor major and channel tags (28a4133)

Bug Fixes

  • publish: fixed potential error without channels (1.2.3) (891829e)
  • package-json: added missing semver in package.json (6db8326)
  • publish: added missing docker tag source (6e6a0c7)
  • publish: fixed formatting (da46c5d)
  • publish: added if clause around latest tag (e23e570)
  • publish: fixed is not a function error (794cb0d)

Contributors

@LucBas, @valmirselmani

@lgaticaq lgaticaq self-requested a review April 6, 2020 14:08
@lgaticaq lgaticaq self-assigned this Apr 6, 2020
@lgaticaq lgaticaq added the enhancement New feature or request label Apr 6, 2020
lgaticaq
lgaticaq requested changes Apr 6, 2020
View reviewed changes
@LucBas
Merge remote-tracking branch 'origin/master'
efda28c 
# Conflicts:
#	lib/publish.js
@L-U-C-K-Y
Copy link
Author

L-U-C-K-Y commented Apr 7, 2020 •
edited
Loading

Sorry for the mess in this PR history.
Changes are implemented, many thanks for your help!
Either squash or let me know if I should open a new one.

@L-U-C-K-Y
Copy link
Author

L-U-C-K-Y commented Apr 8, 2020 •
edited
Loading

During usage in our pipeline, we get the error:
TypeError: semver is not a function

Haven't found a working solution yet

Update:
Tried to require with, but no luck:
const semver = require('semver/preload.js')

Update:
Had to change the syntax as it is not supported in the most recent version

@LucBas
fix(publish): fixed is not a function error
794cb0d 
syntax is not compatible with latest version of semver
@lgaticaq lgaticaq merged commit 5275e2a into lgaticaq:master Apr 8, 2020
lgaticaq pushed a commit that referenced this pull request Apr 8, 2020
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
3aaeffb 
# [2.3.0](v2.2.1...v2.3.0) (2020-04-08)

### Features

* **gitlab-registry:** added minor major and channel tags ([#2](#2)) ([5275e2a](5275e2a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgaticaq lgaticaq lgaticaq requested changes

Assignees

@lgaticaq lgaticaq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@L-U-C-K-Y @lgaticaq @LucBas @valmirselmani