Skip to content

Commit c80f025

Browse files
committed
fix: use the main prop for the application entry point.
npm start will now look at the main property for the entry point. Port 8080 is now set as the default port instead of 3000. This is a fix related to nodeshift-archived/centos7-s2i-nodejs#33\#issuecomment-382587104. fixes nodeshift-starters#44
1 parent 247d294 commit c80f025

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

greeting-service/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@
1111
"coverage": "nyc npm test",
1212
"coveralls": "nyc npm test && nyc report --reporter=text-lcov | coveralls",
1313
"dependencyCheck": "szero . --ci",
14-
"start": "PORT=8080 node ./bin/www",
14+
"start": "node .",
1515
"prepublish": "license-reporter report -s",
1616
"openshift": "nodeshift --strictSSL=false --nodeVersion=8.x --metadata.out=nodeshift-metadata.json",
1717
"postinstall": "license-reporter report -s && license-reporter save -s --xml licenses.xml"
1818
},
19+
"main": "./bin/www",
1920
"repository": {
2021
"type": "git",
2122
"url": "git://github.com/bucharest-gold/nodejs-circuit-breaker.git"

name-service/bin/www

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919
'use strict';
2020
const server = require('../app');
21-
const port = normalizePort(process.env.PORT || '8081');
21+
const port = normalizePort(process.env.PORT || '8080');
2222

2323
server.on('error', onError);
2424

name-service/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"name": "nodejs-circuit-breaker-name",
33
"version": "1.1.2",
4-
"main": "false",
54
"author": "Red Hat, Inc.",
65
"license": "Apache-2.0",
76
"scripts": {
@@ -14,8 +13,9 @@
1413
"prepublish": "license-reporter report -s",
1514
"openshift": "nodeshift --strictSSL=false --nodeVersion=8.x --metadata.out=nodeshift-metadata.json",
1615
"postinstall": "license-reporter report -s && license-reporter save -s --xml licenses.xml",
17-
"start": "PORT=8080 node ./bin/www"
16+
"start": "node ."
1817
},
18+
"main": "./bin/www",
1919
"repository": {
2020
"type": "git",
2121
"url": "git://github.com/bucharest-gold/nodejs-circuit-breaker.git"

0 commit comments

Comments
 (0)