Skip to content

Commit 248d126

Browse files
committed
Fix pkgconfig list handling
1 parent 1bfc64a commit 248d126

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CMakeLists.txt

+6-5
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,19 @@ SET(SDL2_ALL_INCLUDE_DIRS ${SDL2_INCLUDE_DIR})
3232
SET(SDL2_ALL_LIBRARIES ${SDL2_LIBRARY})
3333
SET(SDL2_ALL_PKGCONFIG_MODULES sdl2)
3434
SET(SDL2PP_EXTRA_LIBRARIES ${SDL2MAIN_LIBRARY})
35+
SET(SDL2PP_EXTRA_PKGCONFIG_LIBRARIES ${SDL2MAIN_LIBRARY})
3536

3637
IF(MINGW)
37-
FIND_LIBRARY(MINGW32_LIBRARY NAMES mingw32)
38+
SET(MINGW32_LIBRARY "mingw32" CACHE STRING "mingw32 library")
3839
SET(SDL2PP_EXTRA_LIBRARIES ${MINGW32_LIBRARY} ${SDL2PP_EXTRA_LIBRARIES})
40+
SET(SDL2PP_EXTRA_PKGCONFIG_LIBRARIES "-l${MINGW32_LIBRARY} ${SDL2PP_EXTRA_PKGCONFIG_LIBRARIES}")
3941
ENDIF(MINGW)
4042

4143
IF(SDL2PP_WITH_IMAGE)
4244
FIND_PACKAGE(SDL2_image REQUIRED)
4345
SET(SDL2_ALL_INCLUDE_DIRS ${SDL2_ALL_INCLUDE_DIRS} ${SDL2_IMAGE_INCLUDE_DIR})
4446
SET(SDL2_ALL_LIBRARIES ${SDL2_ALL_LIBRARIES} ${SDL2_IMAGE_LIBRARY})
45-
SET(SDL2_ALL_PKGCONFIG_MODULES ${SDL2_ALL_PKGCONFIG_MODULES} SDL2_image)
47+
SET(SDL2_ALL_PKGCONFIG_MODULES "${SDL2_ALL_PKGCONFIG_MODULES} SDL2_image")
4648
ELSE(SDL2PP_WITH_IMAGE)
4749
MESSAGE(STATUS "SDL2_image support disabled")
4850
ENDIF(SDL2PP_WITH_IMAGE)
@@ -51,7 +53,7 @@ IF(SDL2PP_WITH_TTF)
5153
FIND_PACKAGE(SDL2_ttf REQUIRED)
5254
SET(SDL2_ALL_INCLUDE_DIRS ${SDL2_ALL_INCLUDE_DIRS} ${SDL2_TTF_INCLUDE_DIR})
5355
SET(SDL2_ALL_LIBRARIES ${SDL2_ALL_LIBRARIES} ${SDL2_TTF_LIBRARY})
54-
SET(SDL2_ALL_PKGCONFIG_MODULES ${SDL2_ALL_PKGCONFIG_MODULES} SDL2_ttf)
56+
SET(SDL2_ALL_PKGCONFIG_MODULES "${SDL2_ALL_PKGCONFIG_MODULES} SDL2_ttf")
5557
ELSE(SDL2PP_WITH_TTF)
5658
MESSAGE(STATUS "SDL2_ttf support disabled")
5759
ENDIF(SDL2PP_WITH_TTF)
@@ -60,7 +62,7 @@ IF(SDL2PP_WITH_MIXER)
6062
FIND_PACKAGE(SDL2_mixer REQUIRED)
6163
SET(SDL2_ALL_INCLUDE_DIRS ${SDL2_ALL_INCLUDE_DIRS} ${SDL2_MIXER_INCLUDE_DIR})
6264
SET(SDL2_ALL_LIBRARIES ${SDL2_ALL_LIBRARIES} ${SDL2_MIXER_LIBRARY})
63-
SET(SDL2_ALL_PKGCONFIG_MODULES ${SDL2_ALL_PKGCONFIG_MODULES} SDL2_mixer)
65+
SET(SDL2_ALL_PKGCONFIG_MODULES "${SDL2_ALL_PKGCONFIG_MODULES} SDL2_mixer")
6466
ELSE(SDL2PP_WITH_MIXER)
6567
MESSAGE(STATUS "SDL2_mixer support disabled")
6668
ENDIF(SDL2PP_WITH_MIXER)
@@ -254,7 +256,6 @@ IF(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR)
254256
JOIN_QUOTED("${SDL2PP_EXTRA_LIBRARIES}" SDL2PP_EXTRA_LIBRARIES_STR)
255257
JOIN_QUOTED("${SDL2_ALL_LIBRARIES}" SDL2_ALL_LIBRARIES_STR)
256258
JOIN_QUOTED("${SDL2_ALL_INCLUDE_DIRS}" SDL2_ALL_INCLUDE_DIRS_STR)
257-
JOIN_SIMPLE("${SDL2_ALL_PKGCONFIG_MODULES}" SDL2_ALL_PKGCONFIG_MODULES_STR)
258259

259260
CONFIGURE_FILE(
260261
sdl2pp.pc.in

sdl2pp.pc.in

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ includedir=${prefix}/include
66
Name: sdl2pp
77
Description: C++11 bindings/wrappers for SDL2
88
Version: @SDL2PP_VERSION@
9-
Requires: @SDL2_ALL_PKGCONFIG_MODULES_STR@
9+
Requires: @SDL2_ALL_PKGCONFIG_MODULES@
1010
Conflicts:
11-
Libs: @SDL2PP_EXTRA_LIBRARIES_STR@ -L${libdir} -lSDL2pp
11+
Libs: @SDL2PP_EXTRA_PKGCONFIG_LIBRARIES@ -L${libdir} -lSDL2pp
1212
Cflags: -I${includedir}

0 commit comments

Comments
 (0)