fix: expose full multiaddrs from conn.RemoteMultiaddr

There's no reason _not_ to do this.

Author: Stebalien

conn.go

@@ -80,12 +80,7 @@ func (c *Conn) untagHop() {
 
 // TODO: is it okay to cast c.Conn().RemotePeer() into a multiaddr? might be "user input"
 func (c *Conn) RemoteMultiaddr() ma.Multiaddr {
-	proto := ma.ProtocolWithCode(ma.P_P2P).Name
-	peerid := c.stream.Conn().RemotePeer().Pretty()
-	p2paddr := ma.StringCast(fmt.Sprintf("/%s/%s", proto, peerid))
-
-	circaddr := ma.Cast(ma.CodeToVarint(P_CIRCUIT))
-	return p2paddr.Encapsulate(circaddr)
+	return c.stream.Conn().RemoteMultiaddr().Encapsulate(circuitAddr)
 }
 
 func (c *Conn) LocalMultiaddr() ma.Multiaddr {

go.mod

@@ -11,3 +11,5 @@ require (
 	github.com/multiformats/go-multiaddr v0.0.4
 	github.com/multiformats/go-multiaddr-net v0.0.1
 )
+
+go 1.12

listen.go

@@ -50,7 +50,7 @@ func (l *RelayListener) Addr() net.Addr {
 }
 
 func (l *RelayListener) Multiaddr() ma.Multiaddr {
-	return ma.Cast(ma.CodeToVarint(P_CIRCUIT))
+	return circuitAddr
 }
 
 func (l *RelayListener) Close() error {

transport.go

@@ -20,6 +20,8 @@ var Protocol = ma.Protocol{
 	VCode: ma.CodeToVarint(P_CIRCUIT),
 }
 
+var circuitAddr ma.Multiaddr = ma.Cast(Protocol.VCode)
+
 func init() {
 	ma.AddProtocol(Protocol)
 }