Skip to content

Commit dfc9de6

Browse files
wlynxgsukunrt
authored andcommitted
fix: use quic.Version instead of the deprecated quic.VersionNumber (#2955)
1 parent 59c3236 commit dfc9de6

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

Diff for: p2p/transport/quic/listener.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ type listener struct {
2323
rcmgr network.ResourceManager
2424
privKey ic.PrivKey
2525
localPeer peer.ID
26-
localMultiaddrs map[quic.VersionNumber]ma.Multiaddr
26+
localMultiaddrs map[quic.Version]ma.Multiaddr
2727
}
2828

2929
func newListener(ln quicreuse.Listener, t *transport, localPeer peer.ID, key ic.PrivKey, rcmgr network.ResourceManager) (listener, error) {
30-
localMultiaddrs := make(map[quic.VersionNumber]ma.Multiaddr)
30+
localMultiaddrs := make(map[quic.Version]ma.Multiaddr)
3131
for _, addr := range ln.Multiaddrs() {
3232
if _, err := addr.ValueForProtocol(ma.P_QUIC_V1); err == nil {
3333
localMultiaddrs[quic.Version1] = addr

Diff for: p2p/transport/quic/transport.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ func (t *transport) Listen(addr ma.Multiaddr) (tpt.Listener, error) {
320320

321321
acceptRunner = &acceptLoopRunner{
322322
acceptSem: make(chan struct{}, 1),
323-
muxer: make(map[quic.VersionNumber]chan acceptVal),
323+
muxer: make(map[quic.Version]chan acceptVal),
324324
}
325325
}
326326

Diff for: p2p/transport/quic/virtuallistener.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const acceptBufferPerVersion = 4
1616
type virtualListener struct {
1717
*listener
1818
udpAddr string
19-
version quic.VersionNumber
19+
version quic.Version
2020
t *transport
2121
acceptRunnner *acceptLoopRunner
2222
acceptChan chan acceptVal
@@ -46,11 +46,11 @@ type acceptLoopRunner struct {
4646
acceptSem chan struct{}
4747

4848
muxerMu sync.Mutex
49-
muxer map[quic.VersionNumber]chan acceptVal
49+
muxer map[quic.Version]chan acceptVal
5050
muxerClosed bool
5151
}
5252

53-
func (r *acceptLoopRunner) AcceptForVersion(v quic.VersionNumber) chan acceptVal {
53+
func (r *acceptLoopRunner) AcceptForVersion(v quic.Version) chan acceptVal {
5454
r.muxerMu.Lock()
5555
defer r.muxerMu.Unlock()
5656

@@ -64,7 +64,7 @@ func (r *acceptLoopRunner) AcceptForVersion(v quic.VersionNumber) chan acceptVal
6464
return ch
6565
}
6666

67-
func (r *acceptLoopRunner) RmAcceptForVersion(v quic.VersionNumber, err error) {
67+
func (r *acceptLoopRunner) RmAcceptForVersion(v quic.Version, err error) {
6868
r.muxerMu.Lock()
6969
defer r.muxerMu.Unlock()
7070

@@ -98,7 +98,7 @@ func (r *acceptLoopRunner) sendErrAndClose(err error) {
9898
// innerAccept is the inner logic of the Accept loop. Assume caller holds the
9999
// acceptSemaphore. May return both a nil conn and nil error if it didn't find a
100100
// conn with the expected version
101-
func (r *acceptLoopRunner) innerAccept(l *listener, expectedVersion quic.VersionNumber, bufferedConnChan chan acceptVal) (tpt.CapableConn, error) {
101+
func (r *acceptLoopRunner) innerAccept(l *listener, expectedVersion quic.Version, bufferedConnChan chan acceptVal) (tpt.CapableConn, error) {
102102
select {
103103
// Check if we have a buffered connection first from an earlier Accept call
104104
case v, ok := <-bufferedConnChan:
@@ -150,7 +150,7 @@ func (r *acceptLoopRunner) innerAccept(l *listener, expectedVersion quic.Version
150150
return nil, nil
151151
}
152152

153-
func (r *acceptLoopRunner) Accept(l *listener, expectedVersion quic.VersionNumber, bufferedConnChan chan acceptVal) (tpt.CapableConn, error) {
153+
func (r *acceptLoopRunner) Accept(l *listener, expectedVersion quic.Version, bufferedConnChan chan acceptVal) (tpt.CapableConn, error) {
154154
for {
155155
var conn tpt.CapableConn
156156
var err error

Diff for: p2p/transport/quicreuse/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var quicConfig = &quic.Config{
1212
MaxStreamReceiveWindow: 10 * (1 << 20), // 10 MB
1313
MaxConnectionReceiveWindow: 15 * (1 << 20), // 15 MB
1414
KeepAlivePeriod: 15 * time.Second,
15-
Versions: []quic.VersionNumber{quic.Version1},
15+
Versions: []quic.Version{quic.Version1},
1616
// We don't use datagrams (yet), but this is necessary for WebTransport
1717
EnableDatagrams: true,
1818
}

Diff for: p2p/transport/quicreuse/connmgr.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func (c *ConnManager) DialQUIC(ctx context.Context, raddr ma.Multiaddr, tlsConf
169169

170170
if v == quic.Version1 {
171171
// The endpoint has explicit support for QUIC v1, so we'll only use that version.
172-
quicConf.Versions = []quic.VersionNumber{quic.Version1}
172+
quicConf.Versions = []quic.Version{quic.Version1}
173173
} else {
174174
return nil, errors.New("unknown QUIC version")
175175
}

Diff for: p2p/transport/quicreuse/quic_multiaddr.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var (
1313
quicV1MA = ma.StringCast("/quic-v1")
1414
)
1515

16-
func ToQuicMultiaddr(na net.Addr, version quic.VersionNumber) (ma.Multiaddr, error) {
16+
func ToQuicMultiaddr(na net.Addr, version quic.Version) (ma.Multiaddr, error) {
1717
udpMA, err := manet.FromNetAddr(na)
1818
if err != nil {
1919
return nil, err
@@ -26,8 +26,8 @@ func ToQuicMultiaddr(na net.Addr, version quic.VersionNumber) (ma.Multiaddr, err
2626
}
2727
}
2828

29-
func FromQuicMultiaddr(addr ma.Multiaddr) (*net.UDPAddr, quic.VersionNumber, error) {
30-
var version quic.VersionNumber
29+
func FromQuicMultiaddr(addr ma.Multiaddr) (*net.UDPAddr, quic.Version, error) {
30+
var version quic.Version
3131
var partsBeforeQUIC []ma.Multiaddr
3232
ma.ForEach(addr, func(c ma.Component) bool {
3333
switch c.Protocol().Code {

0 commit comments

Comments
 (0)