Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.

Log invalid mss buffer #27

Closed
achingbrain opened this issue Oct 18, 2022 · 1 comment · Fixed by #30
Closed

Log invalid mss buffer #27

achingbrain opened this issue Oct 18, 2022 · 1 comment · Fixed by #30
Assignees
@mpetrunic
Labels
released

Comments

@achingbrain
Copy link
Member

When the message is invalid we should log the buffer to aid debugging.

https://github.com/libp2p/js-libp2p-multistream-select/blob/master/src/multistream.ts#L85
@p-shahi p-shahi mentioned this issue Nov 8, 2022
Closed
@p-shahi p-shahi added this to js-libp2p Nov 8, 2022
@p-shahi p-shahi moved this to Weekly Candidates in js-libp2p Nov 8, 2022
@mpetrunic mpetrunic self-assigned this Nov 8, 2022
@mpetrunic mpetrunic mentioned this issue Nov 15, 2022
Merged
@mpetrunic mpetrunic moved this from Weekly Candidates to In Review in js-libp2p Nov 15, 2022
Repository owner moved this from In Review to Done in js-libp2p Nov 15, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mpetrunic mpetrunic

Labels
released
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: log invalid buffer libp2p/js-libp2p-multistream-select
2 participants
@achingbrain @mpetrunic