Skip to content

[switch] Swarm can leave lingering sockets if multiple dials in parallel are executed #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviddias opened this issue Mar 28, 2017 · 1 comment
Closed

[switch] Swarm can leave lingering sockets if multiple dials in parallel are executed #443

daviddias opened this issue Mar 28, 2017 · 1 comment
Labels
kind/stale

Comments

@daviddias
Copy link
Member

tl;dr; pull.empty is for gracious leaves, when closing a socket due to having another one successfully connected, we need a proper .close or .destroy. This needs to be propagated with our Connection abstraction.

Ref:
@daviddias daviddias changed the title Swarm can leave lingering sockets if multiple dials in parallel are executed [switch] Swarm can leave lingering sockets if multiple dials in parallel are executed Aug 22, 2019
@daviddias daviddias transferred this issue from libp2p/js-libp2p-switch Aug 22, 2019
@p-shahi
Copy link
Member

p-shahi commented May 30, 2023

Refactored many times since issue was opened. Please re-open in case it's still observed.
Another note: we would be able to observe this in Grafana for long running nodes & customers like Lodestar would also raise an issue

@p-shahi p-shahi closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviddias @p-shahi