chore: address review

Author: vasco-santos

package.json

@@ -47,7 +47,7 @@
     "aegir": "^32.1.0",
     "it-pair": "^1.0.0",
     "it-pipe": "^1.1.0",
-    "libp2p-interfaces": "^0.8.4",
+    "libp2p-interfaces": "libp2p/js-libp2p-interfaces#chore/update-types",
     "streaming-iterables": "^5.0.3",
     "util": "^0.12.3"
   },

src/ip-port-to-multiaddr.js

@@ -1,5 +1,9 @@
 'use strict'
 
+const debug = require('debug')
+const log = Object.assign(debug('libp2p:ip-port-to-multiaddr'), {
+  error: debug('libp2p:ip-port-to-multiaddr:err')
+})
 const multiaddr = require('multiaddr')
 const errCode = require('err-code')
 const { Address4, Address6 } = require('ip-address')
@@ -33,7 +37,7 @@ function ipPortToMultiaddr (ip, port) {
     // Test valid IPv4
     new Address4(ip) // eslint-disable-line no-new
     return multiaddr(`/ip4/${ip}/tcp/${port}`)
-  } catch (_) {}
+  } catch {}
 
   try {
     // Test valid IPv6
@@ -42,7 +46,9 @@ function ipPortToMultiaddr (ip, port) {
       ? multiaddr(`/ip4/${ip6.to4().correctForm()}/tcp/${port}`)
       : multiaddr(`/ip6/${ip}/tcp/${port}`)
   } catch (err) {
-    throw errCode(new Error(`invalid ip:port for creating a multiaddr: ${ip}:${port}`), errors.ERR_INVALID_IP)
+    const errMsg = `invalid ip:port for creating a multiaddr: ${ip}:${port}`
+    log.error(errMsg)
+    throw errCode(new Error(errMsg), errors.ERR_INVALID_IP)
   }
 }
 

src/stream-to-ma-conn.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const abortable = require('abortable-iterator')
+const { source: abortable } = require('abortable-iterator')
 const debug = require('debug')
 const log = debug('libp2p:stream:converter')
 
@@ -25,6 +25,7 @@ const log = debug('libp2p:stream:converter')
  * @param {Multiaddr} streamProperties.localAddr
  * @param {object} [options]
  * @param {AbortSignal} [options.signal]
+ * @returns {MultiaddrConnection}
  */
 function streamToMaConnection ({ stream, remoteAddr, localAddr }, options = {}) {
   const { sink, source } = stream
@@ -51,7 +52,6 @@ function streamToMaConnection ({ stream, remoteAddr, localAddr }, options = {})
       }
       close()
     },
-    // @ts-ignore abortable has no type definitions
     source: options.signal ? abortable(source, options.signal) : source,
     conn: stream,
     localAddr,