fix: remove peer once the peer closes. should fix peer leak (#52)

* fix: remove peer once the peer closes. should fix peer leak

* test: added test to check if peers are leaking

Author: pgte

src/index.js

@@ -70,14 +70,14 @@ class FloodSub extends EventEmitter {
       Connection specifically between me and that Peer"
      */
     let existing = this.peers.get(id)
-    if (existing) {
-      log('already existing peer', id)
-      ++existing._references
-    } else {
+    if (!existing) {
       log('new peer', id)
       this.peers.set(id, peer)
       existing = peer
+
+      peer.once('close', () => this._removePeer(peer))
     }
+    ++existing._references
 
     return existing
   }

src/peer.js

@@ -35,7 +35,7 @@ class Peer extends EventEmitter {
      */
     this.stream = null
 
-    this._references = 1
+    this._references = 0
   }
 
   /**

test/2-nodes.js

@@ -304,13 +304,6 @@ describe('basics between 2 nodes', () => {
       })
     })
 
-    after((done) => {
-      parallel([
-        (cb) => nodeA.stop(cb),
-        (cb) => nodeB.stop(cb)
-      ], done)
-    })
-
     it('peer is removed from the state when connection ends', (done) => {
       nodeA.dial(nodeB.peerInfo, (err) => {
         expect(err).to.not.exist()
@@ -321,10 +314,25 @@ describe('basics between 2 nodes', () => {
           fsA.stop(() => setTimeout(() => {
             expect(first(fsB.peers)._references).to.equal(1)
             done()
-          }, 250))
+          }, 1000))
         }, 1000)
       })
     })
+
+    it('stop one node', (done) => {
+      parallel([
+        (cb) => nodeA.stop(cb),
+        (cb) => nodeB.stop(cb)
+      ], done)
+    })
+
+    it('nodes don\'t have peers in it', (done) => {
+      setTimeout(() => {
+        expect(fsA.peers.size).to.equal(0)
+        expect(fsB.peers.size).to.equal(0)
+        done()
+      }, 1000)
+    })
   })
 
   describe('dial the pubsub protocol on mount', () => {