Skip to content

Commit 7eeed87

Browse files
hugomrdiasvasco-santos
authored andcommitted
fix: reduce bundle size (#28)
1 parent 4b895cf commit 7eeed87

File tree

8 files changed

+37
-59
lines changed

8 files changed

+37
-59
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -41,3 +41,4 @@ test/test-data/go-ipfs-repo/LOG.old
4141

4242
# while testing npm5
4343
package-lock.json
44+
yarn.lock

appveyor.yml

-29
This file was deleted.

package.json

+8-6
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,23 @@
4444
"dependencies": {
4545
"async": "^2.6.1",
4646
"interface-datastore": "~0.6.0",
47-
"libp2p-crypto": "~0.15.0",
48-
"lodash": "^4.17.11",
49-
"pull-stream": "^3.6.9",
47+
"libp2p-crypto": "~0.16.0",
48+
"merge-options": "^1.0.1",
49+
"node-forge": "~0.7.6",
50+
"pull-stream": "^3.6.8",
5051
"sanitize-filename": "^1.6.1"
5152
},
5253
"devDependencies": {
53-
"aegir": "^18.0.2",
54+
"aegir": "^18.0.3",
5455
"chai": "^4.2.0",
55-
"chai-string": "^1.5.0",
56+
"chai-string": "^1.4.0",
5657
"datastore-fs": "~0.7.0",
5758
"datastore-level": "~0.10.0",
5859
"dirty-chai": "^2.0.1",
5960
"level-js": "^4.0.0",
6061
"mocha": "^5.2.0",
61-
"peer-id": "~0.12.1",
62+
"multihashes": "~0.4.14",
63+
"peer-id": "~0.12.2",
6264
"rimraf": "^2.6.3"
6365
},
6466
"contributors": [

src/cms.js

+12-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
'use strict'
22

3-
const async = require('async')
4-
const forge = require('node-forge')
3+
const setImmediate = require('async/setImmediate')
4+
const series = require('async/series')
5+
const detect = require('async/detect')
6+
const waterfall = require('async/waterfall')
7+
require('node-forge/lib/pkcs7')
8+
require('node-forge/lib/pbe')
9+
const forge = require('node-forge/lib/forge')
510
const util = require('./util')
611

712
/**
@@ -39,13 +44,13 @@ class CMS {
3944
*/
4045
encrypt (name, plain, callback) {
4146
const self = this
42-
const done = (err, result) => async.setImmediate(() => callback(err, result))
47+
const done = (err, result) => setImmediate(() => callback(err, result))
4348

4449
if (!Buffer.isBuffer(plain)) {
4550
return done(new Error('Plain data must be a Buffer'))
4651
}
4752

48-
async.series([
53+
series([
4954
(cb) => self.keychain.findKeyByName(name, cb),
5055
(cb) => self.keychain._getPrivateKey(name, cb)
5156
], (err, results) => {
@@ -85,7 +90,7 @@ class CMS {
8590
* @returns {undefined}
8691
*/
8792
decrypt (cmsData, callback) {
88-
const done = (err, result) => async.setImmediate(() => callback(err, result))
93+
const done = (err, result) => setImmediate(() => callback(err, result))
8994

9095
if (!Buffer.isBuffer(cmsData)) {
9196
return done(new Error('CMS data is required'))
@@ -112,7 +117,7 @@ class CMS {
112117
keyId: r.issuer.find(a => a.shortName === 'CN').value
113118
}
114119
})
115-
async.detect(
120+
detect(
116121
recipients,
117122
(r, cb) => self.keychain.findKeyById(r.keyId, (err, info) => cb(null, !err && info)),
118123
(err, r) => {
@@ -124,7 +129,7 @@ class CMS {
124129
return done(err)
125130
}
126131

127-
async.waterfall([
132+
waterfall([
128133
(cb) => self.keychain.findKeyById(r.keyId, cb),
129134
(key, cb) => self.keychain._getPrivateKey(key.name, cb)
130135
], (err, pem) => {

src/keychain.js

+8-10
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@
22
'use strict'
33

44
const sanitize = require('sanitize-filename')
5-
const deepmerge = require('lodash/merge')
5+
const mergeOptions = require('merge-options')
66
const crypto = require('libp2p-crypto')
77
const DS = require('interface-datastore')
8-
const pull = require('pull-stream')
9-
const isString = require('lodash/isString')
10-
const isSafeInteger = require('lodash/isSafeInteger')
8+
const collect = require('pull-stream/sinks/collect')
9+
const pull = require('pull-stream/pull')
1110
const CMS = require('./cms')
1211

1312
const keyPrefix = '/pkcs8/'
@@ -32,7 +31,7 @@ const defaultOptions = {
3231

3332
function validateKeyName (name) {
3433
if (!name) return false
35-
if (!isString(name)) return false
34+
if (typeof name !== 'string') return false
3635
return name === sanitize(name.trim())
3736
}
3837

@@ -107,8 +106,7 @@ class Keychain {
107106
}
108107
this.store = store
109108

110-
const opts = {}
111-
deepmerge(opts, defaultOptions, options)
109+
const opts = mergeOptions(defaultOptions, options)
112110

113111
// Enforce NIST SP 800-132
114112
if (!opts.passPhrase || opts.passPhrase.length < 20) {
@@ -186,11 +184,11 @@ class Keychain {
186184
return _error(callback, `Invalid key name '${name}'`)
187185
}
188186

189-
if (!isString(type)) {
187+
if (typeof type !== 'string') {
190188
return _error(callback, `Invalid key type '${type}'`)
191189
}
192190

193-
if (!isSafeInteger(size)) {
191+
if (!Number.isSafeInteger(size)) {
194192
return _error(callback, `Invalid key size '${size}'`)
195193
}
196194

@@ -246,7 +244,7 @@ class Keychain {
246244
}
247245
pull(
248246
self.store.query(query),
249-
pull.collect((err, res) => {
247+
collect((err, res) => {
250248
if (err) return _error(callback, err)
251249

252250
const info = res.map(r => JSON.parse(r.value))

src/util.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict'
22

3-
const forge = require('node-forge')
3+
require('node-forge/lib/x509')
4+
const forge = require('node-forge/lib/forge')
45
const pki = forge.pki
56
exports = module.exports
67

test/browser.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
/* eslint-env mocha */
22
'use strict'
33

4-
const async = require('async')
4+
const series = require('async/series')
55
const LevelStore = require('datastore-level')
66

77
describe('browser', () => {
88
const datastore1 = new LevelStore('test-keystore-1', { db: require('level-js') })
99
const datastore2 = new LevelStore('test-keystore-2', { db: require('level-js') })
1010

1111
before((done) => {
12-
async.series([
12+
series([
1313
(cb) => datastore1.open(cb),
1414
(cb) => datastore2.open(cb)
1515
], done)
1616
})
1717

1818
after((done) => {
19-
async.series([
19+
series([
2020
(cb) => datastore1.close(cb),
2121
(cb) => datastore2.close(cb)
2222
], done)

test/node.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
const os = require('os')
55
const path = require('path')
66
const rimraf = require('rimraf')
7-
const async = require('async')
7+
const series = require('async/series')
88
const FsStore = require('datastore-fs')
99

1010
describe('node', () => {
@@ -14,14 +14,14 @@ describe('node', () => {
1414
const datastore2 = new FsStore(store2)
1515

1616
before((done) => {
17-
async.series([
17+
series([
1818
(cb) => datastore1.open(cb),
1919
(cb) => datastore2.open(cb)
2020
], done)
2121
})
2222

2323
after((done) => {
24-
async.series([
24+
series([
2525
(cb) => datastore1.close(cb),
2626
(cb) => datastore2.close(cb),
2727
(cb) => rimraf(store1, cb),

0 commit comments

Comments
 (0)