test: ensure that libp2p nodes are shutdown in identify service spec

Author: maschad

test/identify/service.spec.ts

@@ -67,7 +67,10 @@ describe('identify', () => {
 
     // The connection should have no open streams
     await pWaitFor(() => connection.streams.length === 0)
+
     await connection.close()
+    
+    await libp2p.stop()
   })
 
   it('should emit peer:identify event after connecting', async () => {
@@ -79,11 +82,11 @@ describe('identify', () => {
     }))
 
     await libp2p.start()
-
+  
     if (libp2p.services.identify == null) {
       throw new Error('Identity service was not configured')
     }
-
+    
     const eventPromise = pEvent<'peer:identify', CustomEvent<IdentifyResult>>(libp2p, 'peer:identify')
 
     const connection = await libp2p.dial(remoteAddr)
@@ -95,7 +98,10 @@ describe('identify', () => {
     const remotePeer = peerIdFromString(remoteAddr.getPeerId() ?? '')
 
     expect(event.detail.peerId.equals(remotePeer)).to.be.true()
+
     await connection.close()
+    
+    await libp2p.stop()
   })
 
   it('should store remote agent and protocol versions in metadataBook after connecting', async () => {
@@ -129,6 +135,8 @@ describe('identify', () => {
     const remotePeer = await libp2p.peerStore.get(remotePeerId)
     expect(remotePeer.metadata.get('AgentVersion')).to.exist()
     expect(remotePeer.metadata.get('ProtocolVersion')).to.exist()
+
+    await libp2p.stop()
   })
 
   it('should push protocol updates to an already connected peer', async () => {

test/upgrading/upgrader.spec.ts

@@ -668,8 +668,7 @@ describe('libp2p.upgrader', () => {
     expect(arg0.stream).to.include.keys(['id', 'recvWindowCapacity', 'sendWindowCapacity', 'sourceInput'])
   })
 
-  // #TODO Investigate why this is failing https://github.com/libp2p/js-libp2p/issues/1781, skipping for now based https://github.com/libp2p/js-libp2p/pull/1627#issuecomment-1570561645
-  it.skip('should emit connect and disconnect events', async () => {
+  it('should emit connect and disconnect events', async () => {
     const remotePeer = peers[1]
     libp2p = await createLibp2p({
       peerId: peers[0],