Skip to content

Commit b33aca0

Browse files
committed
chore: address review
1 parent 340edf5 commit b33aca0

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
"libp2p-delegated-content-routing": "^0.2.2",
9393
"libp2p-delegated-peer-routing": "^0.2.2",
9494
"libp2p-floodsub": "^0.19.0",
95-
"libp2p-gossipsub": "ChainSafe/gossipsub-js#refactor/async",
95+
"libp2p-gossipsub": "ChainSafe/gossipsub-js#beta/async",
9696
"libp2p-kad-dht": "^0.15.3",
9797
"libp2p-mdns": "^0.12.3",
9898
"libp2p-mplex": "^0.9.1",

src/registrar.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const log = debug('libp2p:peer-store')
66
log.error = debug('libp2p:peer-store:error')
77

88
const Topology = require('libp2p-interfaces/src/topology')
9-
const MulticodecTopology = require('libp2p-interfaces/src/topology/multicodec-topology')
109
const { Connection } = require('libp2p-interfaces/src/connection')
1110
const PeerInfo = require('peer-info')
1211

@@ -112,8 +111,7 @@ class Registrar {
112111
*/
113112
register (topology) {
114113
assert(
115-
Topology.isTopology(topology) ||
116-
MulticodecTopology.isMulticodecTopology(topology),
114+
Topology.isTopology(topology),
117115
'topology must be an instance of interfaces/topology')
118116

119117
// Create topology

test/pubsub/operation.node.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,10 @@ describe('Pubsub subsystem operates correctly', () => {
140140

141141
remoteLibp2p.pubsub.start()
142142

143-
await pWaitFor(() => libp2p.pubsub._pubsub.peers.size === 1)
143+
await pWaitFor(() =>
144+
libp2p.pubsub._pubsub.peers.size === 1 &&
145+
remoteLibp2p.pubsub._pubsub.peers.size === 1
146+
)
144147

145148
expect(libp2p.pubsub._pubsub.peers.size).to.be.eql(1)
146149
expect(remoteLibp2p.pubsub._pubsub.peers.size).to.be.eql(1)

0 commit comments

Comments
 (0)