Skip to content

Commit b8f66cd

Browse files
richardschneiderdaviddias
authored andcommitted
fix: Published message field names (#49)
* fix: topicCIDs should be topicIDs * fix: use supported node versions
1 parent 45c2f8e commit b8f66cd

File tree

4 files changed

+12
-17
lines changed

4 files changed

+12
-17
lines changed

.travis.yml

+7-12
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
sudo: false
22
language: node_js
3-
node_js:
4-
- 4
5-
- 5
6-
- stable
7-
8-
# Make sure we have new NPM.
9-
before_install:
10-
- npm install -g npm
3+
matrix:
4+
include:
5+
- node_js: 6
6+
env: CXX=g++-4.8
7+
- node_js: 8
8+
env: CXX=g++-4.8
119

1210
script:
1311
- npm run lint
14-
- npm test
12+
- npm run test
1513
- npm run coverage
1614

1715

@@ -22,9 +20,6 @@ before_script:
2220
after_success:
2321
- npm run coverage-publish
2422

25-
env:
26-
- CXX=g++-4.8
27-
2823
addons:
2924
firefox: 'latest'
3025
apt:

src/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,10 @@ class FloodSub extends EventEmitter {
157157
this.cache.put(seqno)
158158

159159
// 2. emit to self
160-
this._emitMessages(msg.topicCIDs, [msg])
160+
this._emitMessages(msg.topicIDs, [msg])
161161

162162
// 3. propagate msg to others
163-
this._forwardMessages(msg.topicCIDs, [msg])
163+
this._forwardMessages(msg.topicIDs, [msg])
164164
})
165165
}
166166

@@ -277,7 +277,7 @@ class FloodSub extends EventEmitter {
277277
from: from,
278278
data: msg,
279279
seqno: new Buffer(seqno),
280-
topicCIDs: topics
280+
topicIDs: topics
281281
}
282282
}
283283

src/message/rpc.proto.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ message RPC {
1313
optional string from = 1;
1414
optional bytes data = 2;
1515
optional bytes seqno = 3;
16-
repeated string topicCIDs = 4; // CID of topic descriptor object
16+
repeated string topicIDs = 4; // CID of topic descriptor object
1717
}
1818
}`

test/2-nodes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe('basics between 2 nodes', () => {
131131
expect(msg.data.toString()).to.equal('banana')
132132
expect(msg.from).to.be.eql(fsB.libp2p.peerInfo.id.toB58String())
133133
expect(Buffer.isBuffer(msg.seqno)).to.be.true()
134-
expect(msg.topicCIDs).to.be.eql(['Z'])
134+
expect(msg.topicIDs).to.be.eql(['Z'])
135135

136136
if (++counter === 10) {
137137
fsA.removeListener('Z', receivedMsg)

0 commit comments

Comments
 (0)