Skip to content

Commit d206a25

Browse files
chore: apply suggestions from code review
Co-authored-by: Alex Potsides <[email protected]>
1 parent 8e91334 commit d206a25

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/main.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v2
1515
- run: npm install
1616
- run: npx aegir lint
17-
- run: npx aegir ts -p check
17+
- uses: gozala/[email protected]
1818
- run: npx aegir build
1919
- run: npx aegir dep-check
2020
- uses: ipfs/aegir/actions/bundle-size@master
@@ -35,7 +35,7 @@ jobs:
3535
with:
3636
node-version: ${{ matrix.node }}
3737
- run: npm install
38-
- run: npx nyc --reporter=lcov aegir test -t node -- --bail
38+
- run: npx aegir test -t node --cov --bail
3939
- uses: codecov/codecov-action@v1
4040
test-chrome:
4141
needs: check
@@ -50,7 +50,7 @@ jobs:
5050
steps:
5151
- uses: actions/checkout@v2
5252
- run: npm install
53-
- run: npx aegir test -t browser -t webworker --bail -- --browsers FirefoxHeadless
53+
- run: npx aegir test -t browser -t webworker --bail -- --browser firefox
5454
test-ts:
5555
needs: check
5656
runs-on: ubuntu-latest

test/core/ping.node.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ describe('ping', () => {
5858
if (firstInvocation) {
5959
firstInvocation = false
6060

61-
for await (const data of stream) { // eslint-disable-line
61+
// eslint-disable-next-line no-unreachable-loop
62+
for await (const data of stream) {
6263
return {
6364
value: data,
6465
done: false

0 commit comments

Comments
 (0)