Skip to content

feat: support streaming hashes for key sign/verify #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2023
Merged

feat: support streaming hashes for key sign/verify #2255

merged 2 commits into from
Nov 25, 2023

Conversation

achingbrain
Copy link
Member

Accept Uint8ArrayLists as arguments to sign or verify and use streaming hashes internally when they are passed (if supported). This way we can skip having to copy the Uint8ArrayList contents into a Uint8Array first.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: support streaming hashes
cb6b668 
Accept `Uint8ArrayList`s as arguments to sign or verify and use
streaming hashes internally when they are passed. This way we can
skip having to copy the `Uint8ArrayList` contents into a `Uint8Array`
first.
@achingbrain
chore: use uintarray concat because it is faster
6b91682
@achingbrain achingbrain requested a review from a team as a code owner November 25, 2023 12:10
@achingbrain achingbrain changed the title feat: support streaming hashes feat: support streaming hashes for key sign/verify Nov 25, 2023
@achingbrain achingbrain merged commit ac7bc38 into main Nov 25, 2023
@achingbrain achingbrain deleted the feat/support-streaming-sign-verify branch November 25, 2023 13:30
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Nov 27, 2023
@achingbrain @maschad
feat: support streaming hashes for key sign/verify (libp2p#2255)
1dc83ed 
Accept `Uint8ArrayList`s as arguments to sign or verify and use
streaming hashes internally when they are passed. This way we can
skip having to copy the `Uint8ArrayList` contents into a `Uint8Array`
first.
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @wemeetagain