Skip to content

DHT ping failing when pinging a rust peer #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dozyio opened this issue Apr 9, 2025 · 0 comments · Fixed by #3074
Closed

DHT ping failing when pinging a rust peer #3072

dozyio opened this issue Apr 9, 2025 · 0 comments · Fixed by #3074
Labels
need/triage Needs initial labeling and prioritization

Comments

@dozyio
Copy link
Contributor

dozyio commented Apr 9, 2025

  • Version: kad-dht 14.2.15

  • Platform: all

  • Subsystem: kad-dht

Severity:

High

Description:

  • What you did
    Attempt bootstrap a DHT from rust peers

  • What happened
    Before a peer is added to the routing table, the JS peer performs a DHT ping. The DHT ping is unsupported in rust and is deprecated, thus adding a rust peer fails.

  • What you expected to happen
    A JS peer adds the rust peer to its routing table

Proposed fix is to replace DHT ping with a libp2p ping as recommended by the spec

Steps to reproduce the error:

See #3058
@dozyio dozyio added the need/triage Needs initial labeling and prioritization label Apr 9, 2025
@achingbrain achingbrain mentioned this issue Apr 9, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: use libp2p ping instad of kad ping libp2p/js-libp2p
1 participant
@dozyio