test: Remove dialer_can_receive stream muxer test (#3108)

Various muxer implementations struggle to fulfill this test. In practice, it doesn't matter much because we always run `multistream-select` on top of a newly negotiated stream so we never end up actually reading from a stream that we have never written to.

Relevant discussion: kpp#27 (comment)

Author: thomaseizinger

muxers/mplex/tests/compliance.rs

@@ -9,15 +9,6 @@ async fn close_implies_flush() {
     libp2p_muxer_test_harness::close_implies_flush(alice, bob).await;
 }
 
-#[async_std::test]
-async fn dialer_can_receive() {
-    let (alice, bob) =
-        libp2p_muxer_test_harness::connected_muxers_on_memory_transport::<MplexConfig, _, _>()
-            .await;
-
-    libp2p_muxer_test_harness::dialer_can_receive(alice, bob).await;
-}
-
 #[async_std::test]
 async fn read_after_close() {
     let (alice, bob) =

muxers/test-harness/src/lib.rs

@@ -80,31 +80,6 @@ where
     .await;
 }
 
-/// Verifies that the dialer of a substream can receive a message.
-pub async fn dialer_can_receive<A, B, S, E>(alice: A, bob: B)
-where
-    A: StreamMuxer<Substream = S, Error = E> + Unpin,
-    B: StreamMuxer<Substream = S, Error = E> + Unpin,
-    S: AsyncRead + AsyncWrite + Send + Unpin + 'static,
-    E: fmt::Debug,
-{
-    run_commutative(
-        alice,
-        bob,
-        |mut stream| async move {
-            let mut buf = Vec::new();
-            stream.read_to_end(&mut buf).await.unwrap();
-
-            assert_eq!(buf, b"PING");
-        },
-        |mut stream| async move {
-            stream.write_all(b"PING").await.unwrap();
-            stream.close().await.unwrap();
-        },
-    )
-    .await;
-}
-
 /// Verifies that we can "half-close" a substream.
 pub async fn read_after_close<A, B, S, E>(alice: A, bob: B)
 where

muxers/yamux/tests/compliance.rs

@@ -9,16 +9,6 @@ async fn close_implies_flush() {
     libp2p_muxer_test_harness::close_implies_flush(alice, bob).await;
 }
 
-#[async_std::test]
-#[ignore] // Hangs forever, is this a harness bug? It passes if we try to write to the stream.
-async fn dialer_can_receive() {
-    let (alice, bob) =
-        libp2p_muxer_test_harness::connected_muxers_on_memory_transport::<YamuxConfig, _, _>()
-            .await;
-
-    libp2p_muxer_test_harness::dialer_can_receive(alice, bob).await;
-}
-
 #[async_std::test]
 async fn read_after_close() {
     let (alice, bob) =