f rename max fee variant

Author: TheBlueMatt

lightning/src/chain/chaininterface.rs

@@ -49,12 +49,12 @@ pub trait BroadcasterInterface {
 /// estimation.
 #[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
 pub enum ConfirmationTarget {
-	/// The most conservative (i.e. highest) feerate estimate available.
+	/// The most aggressive (i.e. highest) feerate estimate available.
 	///
 	/// This is use to sanity-check our counterparty's feerates and should be as conservative as
 	/// possible to ensure that we don't confuse a peer using a very conservative estimator for one
 	/// trying to burn channel balance to dust.
-	MostConservativeEstimate,
+	MaximumFeeEstimate,
 	/// We have some funds available on chain which we need to spend prior to some expiry time at
 	/// which point our counterparty may be able to steal them. Generally we have in the high tens
 	/// to low hundreds of blocks to get our transaction on-chain, but we shouldn't risk too low a

lightning/src/ln/channel.rs

@@ -2442,7 +2442,7 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider  {
 	fn get_dust_exposure_limiting_feerate<F: Deref>(&self,
 		fee_estimator: &LowerBoundedFeeEstimator<F>,
 	) -> u32 where F::Target: FeeEstimator {
-		fee_estimator.bounded_sat_per_1000_weight(ConfirmationTarget::MostConservativeEstimate)
+		fee_estimator.bounded_sat_per_1000_weight(ConfirmationTarget::MaximumFeeEstimate)
 	}
 
 	pub fn get_max_dust_htlc_exposure_msat(&self, limiting_feerate_sat_per_kw: u32) -> u64 {

lightning/src/util/config.rs

@@ -382,7 +382,7 @@ pub enum MaxDustHTLCExposure {
 	/// to this maximum the channel may be unable to send/receive HTLCs between the maximum dust
 	/// exposure and the new minimum value for HTLCs to be economically viable to claim.
 	FixedLimitMsat(u64),
-	/// This sets a multiplier on the [`ConfirmationTarget::MostConservativeEstimate`] feerate (in
+	/// This sets a multiplier on the [`ConfirmationTarget::MaximumFeeEstimate`] feerate (in
 	/// sats/KW) to determine the maximum allowed dust exposure. If this variant is used then the
 	/// maximum dust exposure in millisatoshis is calculated as:
 	/// `feerate_per_kw * value`. For example, with our default value
@@ -407,7 +407,7 @@ pub enum MaxDustHTLCExposure {
 	/// by default this will be set to a [`Self::FixedLimitMsat`] of 5,000,000 msat.
 	///
 	/// [`FeeEstimator`]: crate::chain::chaininterface::FeeEstimator
-	/// [`ConfirmationTarget::MostConservativeEstimate`]: crate::chain::chaininterface::ConfirmationTarget::MostConservativeEstimate
+	/// [`ConfirmationTarget::MaximumFeeEstimate`]: crate::chain::chaininterface::ConfirmationTarget::MaximumFeeEstimate
 	FeeRateMultiplier(u64),
 }