Skip to content

Commit 8c76a69

Browse files
committed
f - don't hardcode Iterable
1 parent 3ebce4b commit 8c76a69

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

lightning/src/offers/invoice.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,8 @@ impl TryFrom<Vec<u8>> for Invoice {
440440
}
441441

442442
tlv_stream!(InvoiceTlvStream, InvoiceTlvStreamRef, 160..240, {
443-
(160, paths: (Vec<BlindedPath>, Iterable<'a, BlindedPathIter<'a>, BlindedPath>)),
444-
(162, blindedpay: (Vec<BlindedPayInfo>, Iterable<'a, BlindedPayInfoIter<'a>, BlindedPayInfo>)),
443+
(160, paths: (Vec<BlindedPath>, WithoutLength, Iterable<'a, BlindedPathIter<'a>, BlindedPath>)),
444+
(162, blindedpay: (Vec<BlindedPayInfo>, WithoutLength, Iterable<'a, BlindedPayInfoIter<'a>, BlindedPayInfo>)),
445445
(164, created_at: (u64, HighZeroBytesDroppedBigSize)),
446446
(166, relative_expiry: (u32, HighZeroBytesDroppedBigSize)),
447447
(168, payment_hash: PaymentHash),

lightning/src/util/ser_macros.rs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,8 @@ macro_rules! decode_tlv {
184184
($reader: expr, $field: ident, (option: $trait: ident $(, $read_arg: expr)?)) => {{
185185
$field = Some($trait::read(&mut $reader $(, $read_arg)*)?);
186186
}};
187-
($reader: expr, $field: ident, (option, encoding: ($fieldty: ty, Iterable<$lifetime:lifetime, $itertype:ty, $valuetype:ty>))) => {{
188-
$field = {
189-
let field: $crate::util::ser::WithoutLength<$fieldty> = ser::Readable::read(&mut $reader)?;
190-
Some(field.0)
191-
};
187+
($reader: expr, $field: ident, (option, encoding: ($fieldty: ty, $encoding: ident, $encoder:ty))) => {{
188+
decode_tlv!($reader, $field, (option, encoding: ($fieldty, $encoding)));
192189
}};
193190
($reader: expr, $field: ident, (option, encoding: ($fieldty: ty, $encoding: ident))) => {{
194191
$field = {
@@ -555,8 +552,8 @@ macro_rules! tlv_stream {
555552
}
556553

557554
macro_rules! tlv_record_type {
558-
(($type:ty, Iterable<$lifetime:lifetime, $itertype:ty, $valuetype:ty>)) => { $type };
559555
(($type:ty, $wrapper:ident)) => { $type };
556+
(($type:ty, $wrapper:ident, $encoder:ty)) => { $type };
560557
($type:ty) => { $type };
561558
}
562559

@@ -566,10 +563,8 @@ macro_rules! tlv_record_ref_type {
566563
((u16, $wrapper: ident)) => { u16 };
567564
((u32, $wrapper: ident)) => { u32 };
568565
((u64, $wrapper: ident)) => { u64 };
569-
(($type:ty, Iterable<$lifetime:lifetime, $itertype:ty, $valuetype:ty>)) => {
570-
Iterable<$lifetime, $itertype, $valuetype>
571-
};
572566
(($type:ty, $wrapper:ident)) => { &'a $type };
567+
(($type:ty, $wrapper:ident, $encoder:ty)) => { $encoder };
573568
($type:ty) => { &'a $type };
574569
}
575570

0 commit comments

Comments
 (0)