Skip to content

Ability to construct an invoice from bindings #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheBlueMatt opened this issue Nov 22, 2022 · 3 comments
Open

Ability to construct an invoice from bindings #1868

TheBlueMatt opened this issue Nov 22, 2022 · 3 comments

Comments

@TheBlueMatt
Copy link
Collaborator

Most languages don't support move semantics, so the standard rust builder pattern doesn't work. Worse, the invoice construction builder has a ton of type info that enforces downstream correctness. Realistically, we probably need to expose a full #[cfg(c_bindings)] invoice constructor that is parallel with the rust one.
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Nov 22, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Jan 18, 2023
Open
60 tasks
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.114, 0.0.115 Jan 31, 2023
@TheBlueMatt
Copy link
Collaborator Author

Gonna slip this.

@dunxen dunxen self-assigned this Feb 6, 2023
@TheBlueMatt
Copy link
Collaborator Author

Slipping to 0.1.

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.115, 0.1 Apr 17, 2023
@TheBlueMatt
Copy link
Collaborator Author

Surprisingly, with the utils, no one has actually complained about this, so removing the milestone entirely.

@TheBlueMatt TheBlueMatt removed this from the 0.1 milestone May 6, 2024
@dunxen dunxen removed their assignment Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @dunxen