Skip to content

Persist NetworkGraph in BP upon RGS updates #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tnull opened this issue Mar 20, 2023 · 2 comments · Fixed by #2226
Closed

Persist NetworkGraph in BP upon RGS updates #2117

tnull opened this issue Mar 20, 2023 · 2 comments · Fixed by #2226
Milestone

Comments

@tnull
Copy link
Contributor

tnull commented Mar 20, 2023

Currently, we persist the network graph after a minute, then hourly, and finally on shutdown.

As the hourly interval is very conservative and mostly makes sense on a 24/7 server and the initial delay of 1 minute could be too long or too short, we should switch to a polling-based logic in case we get our graph data via RapidGossipSync.

@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Mar 20, 2023
@TheBlueMatt
Copy link
Collaborator

Oops I think we had a minor regression here, too, we used to always poll after 60s but now with #2081 we check after 60s and then poll every 3600s. Of course with RGS you almost always complete within 60s and the app is usually closed before 60s, so its not a big regression - we were screwed already, but worth noting.

@tnull tnull changed the title Switch BP persistence of NetworkGraph to polling for RGS being updated Persist NetworkGraph in BP upon RGS updates Mar 20, 2023
@TheBlueMatt
Copy link
Collaborator

Slipping to 116, this is pretty easy to do but not super critical. While we're at it we should also persist the scorer any time its been updated based on the event handler, rather than (or in addition to) on a timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants