Skip to content

Add htlctimeout reason to closure reasons #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue May 9, 2023 · 2 comments · Fixed by #2887
Closed

Add htlctimeout reason to closure reasons #2283

TheBlueMatt opened this issue May 9, 2023 · 2 comments · Fixed by #2887
Labels
good first issue Good for newcomers
Milestone
0.0.123

Comments

@TheBlueMatt
Copy link
Collaborator

In the issue I hit with #2282 the monitor closed the channel and this resulted in a CommitmentConfirmed shutdown reason, which is nonsense, I force-closed!
@TheBlueMatt TheBlueMatt added this to the 0.0.116 milestone May 9, 2023
@TheBlueMatt
Copy link
Collaborator Author

This is kinda important cause the API is braindead, but given how little time is left for 116 and how much work is left for it, this doesn't need to go now.

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.116, 0.0.117 Jun 1, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.117, 0.0.118 Aug 31, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.118, 0.0.119 Oct 12, 2023
@TheBlueMatt
Copy link
Collaborator Author

Ugh we really do need this but.... time.

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.119, 0.0.120 Nov 30, 2023
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Jan 9, 2024
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.120 , 0.0.121 Jan 9, 2024
@benthecarman benthecarman mentioned this issue Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.0.123
Development

Successfully merging a pull request may close this issue.

Add HTLCsTimedOut closing reason benthecarman/rust-lightning
1 participant
@TheBlueMatt