Skip to content

[bug]: provide more details on the new RBF cooperative close feature in release notes #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZZiigguurraatt opened this issue Apr 28, 2025 · 2 comments · Fixed by #9776
Closed
Assignees
Labels
documentation Documentation changes that do not affect code behaviour
Milestone

Comments

@ZZiigguurraatt
Copy link

In the latest release notes, we have

* `lnd` now [supports the new RBF cooperative close
flow](https://github.com/lightningnetwork/lnd/pull/9610). Unlike the old
flow, this version now uses RBF to enable either side to increase their fee
rate using their _own_ channel funds. This removes the old "negotiation"
logic that could fail, with a version where either side can increase the fee
on their coop close transaction using their channel balance.
This new feature can be activated with a new config flag:
`--protocol.rbf-coop-close`.
With this new co-op close type, users can issue multiple `lncli closechannnel`
commands with increasing fee rates to use RBF to bump an existing signed co-op
close transaction.

which links to a PR that has no description and a bunch of commits.

This is a big and powerful change that I think we should more clearly explain to users in english what is going on and what it is compatible with.

Some key points that I think we should mention:

@ZZiigguurraatt ZZiigguurraatt added bug Unintended code behaviour needs triage labels Apr 28, 2025
@ZZiigguurraatt
Copy link
Author

which links to a PR

https://bitcoinops.org/en/newsletters/2025/03/28/#lnd-8453 also mentions a number of additional PR related to this feature. Are these PR also relevant and worth mentioning or is Bitcoin Optech wrong?

@saubyk saubyk added documentation Documentation changes that do not affect code behaviour and removed bug Unintended code behaviour needs triage labels Apr 29, 2025
@ZZiigguurraatt
Copy link
Author

We also need to make it clear that it does not work in the following situations:

  1. taproot channels ([feature]: add taproot chan support to rbf-closer #9662)
  2. custom channels ([feature]: add custom chan support to new rbf chan closer #9663)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes that do not affect code behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants