[django] Setup pytest-django (#995)

* [django] Setup pytest-django

* fix djangorestframework tests

Author: brettlangdon

tests/contrib/django/conftest.py

@@ -0,0 +1,16 @@
+import os
+import django
+from django.conf import settings
+
+# We manually designate which settings we will be using in an environment variable
+# This is similar to what occurs in the `manage.py`
+os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'tests.contrib.django.app.settings')
+
+
+# `pytest` automatically calls this function once when tests are run.
+def pytest_configure():
+    settings.DEBUG = False
+    if django.VERSION < (1, 7, 0):
+        settings.configure()
+    else:
+        django.setup()

tests/contrib/djangorestframework/app/settings.py

@@ -21,7 +21,7 @@
 USE_I18N = True
 USE_L10N = True
 STATIC_URL = '/static/'
-ROOT_URLCONF = 'app.views'
+ROOT_URLCONF = 'tests.contrib.djangorestframework.app.views'
 
 TEMPLATES = [
     {
@@ -111,5 +111,5 @@
         'rest_framework.permissions.IsAdminUser',
     ],
 
-    'EXCEPTION_HANDLER': 'app.exceptions.custom_exception_handler'
+    'EXCEPTION_HANDLER': 'tests.contrib.djangorestframework.app.exceptions.custom_exception_handler'
 }

tests/contrib/djangorestframework/conftest.py

@@ -0,0 +1,16 @@
+import os
+import django
+from django.conf import settings
+
+# We manually designate which settings we will be using in an environment variable
+# This is similar to what occurs in the `manage.py`
+os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'tests.contrib.djangorestframework.app.settings')
+
+
+# `pytest` automatically calls this function once when tests are run.
+def pytest_configure():
+    settings.DEBUG = False
+    if django.VERSION < (1, 7, 0):
+        settings.configure()
+    else:
+        django.setup()

tests/contrib/djangorestframework/runtests.py

@@ -35,7 +35,7 @@ def test_unpatch(self):
         assert len(spans) == 1
         sp = spans[0]
         assert sp.name == 'django.request'
-        assert sp.resource == 'app.views.UserViewSet'
+        assert sp.resource == 'tests.contrib.djangorestframework.app.views.UserViewSet'
         assert sp.error == 0
         assert sp.span_type == 'http'
         assert sp.get_tag('http.status_code') == '500'
@@ -52,7 +52,7 @@ def test_trace_exceptions(self):
         assert len(spans) == 1
         sp = spans[0]
         assert sp.name == 'django.request'
-        assert sp.resource == 'app.views.UserViewSet'
+        assert sp.resource == 'tests.contrib.djangorestframework.app.views.UserViewSet'
         assert sp.error == 1
         assert sp.span_type == 'http'
         assert sp.get_tag('http.method') == 'GET'

tests/contrib/djangorestframework/test_djangorestframework.py

@@ -138,6 +138,7 @@ deps =
     pytest>=3
     pytest-benchmark
     pytest-cov
+    pytest-django
     opentracing
     psutil
 # test dependencies installed in all envs
@@ -378,9 +379,9 @@ commands =
     cassandra_contrib: pytest {posargs} tests/contrib/cassandra
     celery_contrib: pytest {posargs} tests/contrib/celery
     dbapi_contrib: pytest {posargs} tests/contrib/dbapi
-    django_contrib: python tests/contrib/django/runtests.py {posargs}
-    django_contrib_autopatch: python tests/ddtrace_run.py python tests/contrib/django/runtests.py {posargs}
-    django_drf_contrib: python tests/contrib/djangorestframework/runtests.py {posargs}
+    django_contrib: pytest {posargs} tests/contrib/django
+    django_contrib_autopatch: python tests/ddtrace_run.py pytest {posargs} tests/contrib/django
+    django_drf_contrib: pytest {posargs} tests/contrib/djangorestframework
     elasticsearch_contrib: pytest {posargs} tests/contrib/elasticsearch
     falcon_contrib: pytest {posargs} tests/contrib/falcon/test_middleware.py tests/contrib/falcon/test_distributed_tracing.py
     falcon_contrib_autopatch: python tests/ddtrace_run.py pytest {posargs} tests/contrib/falcon/test_autopatch.py
@@ -423,9 +424,6 @@ commands =
     unit_tests: pytest {posargs} tests/unit
     benchmarks: pytest --benchmark-only {posargs} tests/benchmark.py
 
-setenv =
-    DJANGO_SETTINGS_MODULE = app.settings
-
 [testenv:wait]
 commands=python tests/wait-for-services.py {posargs}
 basepython=python