[testing] Remove nose usage

This has been deprecated and unmaintained for years; stop installing it.

- Replaces `nose.tools.ok_` with `assert`
- Replaces `nose.tools.eq_` with `assert ==`
- Replaces `nose.tools.assert_raises` with `pytest.raises`
- Add missing unittest.TestCase inheritance in some place
- Only install requests-mock for requests_contrib scenarios;
  this modules has a pytest plugin that gets loaded otherwise and pre-load
- `requests`, making some test checking for module load ordering fail.

Author: jd

.gitignore

@@ -41,7 +41,6 @@ htmlcov/
 .coverage
 .coverage.*
 .cache
-nosetests.xml
 coverage.xml
 *,cover
 .hypothesis/

setup.cfg

@@ -1,5 +1,2 @@
-[nosetests]
-verbosity=1
-
 [bdist_wheel]
 universal=1

tests/commands/ddtrace_run_argv.py

@@ -1,6 +1,5 @@
-from nose.tools import eq_
 import sys
 
 if __name__ == '__main__':
-    eq_(sys.argv[1:], ['foo', 'bar'])
+    assert sys.argv[1:] == ['foo', 'bar']
     print('Test success')

tests/commands/ddtrace_run_debug.py

@@ -1,7 +1,5 @@
 from ddtrace import tracer
 
-from nose.tools import ok_
-
 if __name__ == '__main__':
-    ok_(tracer.debug_logging)
+    assert tracer.debug_logging
     print("Test success")

tests/commands/ddtrace_run_disabled.py

@@ -1,8 +1,6 @@
 from ddtrace import tracer, monkey
 
-from nose.tools import ok_, eq_
-
 if __name__ == '__main__':
-    ok_(not tracer.enabled)
-    eq_(len(monkey.get_patched_modules()), 0)
+    assert not tracer.enabled
+    assert len(monkey.get_patched_modules()) == 0
     print("Test success")

tests/commands/ddtrace_run_enabled.py

@@ -1,7 +1,5 @@
 from ddtrace import tracer
 
-from nose.tools import ok_
-
 if __name__ == '__main__':
-    ok_(tracer.enabled)
+    assert tracer.enabled
     print("Test success")

tests/commands/ddtrace_run_env.py

@@ -1,7 +1,5 @@
 from ddtrace import tracer
 
-from nose.tools import eq_
-
 if __name__ == '__main__':
-    eq_(tracer.tags['env'], 'test')
+    assert tracer.tags['env'] == 'test'
     print('Test success')

tests/commands/ddtrace_run_hostname.py

@@ -1,8 +1,6 @@
 from ddtrace import tracer
 
-from nose.tools import eq_
-
 if __name__ == '__main__':
-    eq_(tracer.writer.api.hostname, "172.10.0.1")
-    eq_(tracer.writer.api.port, 8120)
+    assert tracer.writer.api.hostname == "172.10.0.1"
+    assert tracer.writer.api.port == 8120
     print("Test success")

tests/commands/ddtrace_run_integration.py

@@ -9,40 +9,38 @@
 from tests.contrib.config import REDIS_CONFIG
 from tests.test_tracer import DummyWriter
 
-from nose.tools import eq_, ok_
-
 if __name__ == '__main__':
     r = redis.Redis(port=REDIS_CONFIG['port'])
     pin = Pin.get_from(r)
-    ok_(pin)
-    eq_(pin.app, 'redis')
-    eq_(pin.service, 'redis')
+    assert pin
+    assert pin.app == 'redis'
+    assert pin.service == 'redis'
 
     pin.tracer.writer = DummyWriter()
     r.flushall()
     spans = pin.tracer.writer.pop()
 
-    eq_(len(spans), 1)
-    eq_(spans[0].service, 'redis')
-    eq_(spans[0].resource, 'FLUSHALL')
+    assert len(spans) == 1
+    assert spans[0].service == 'redis'
+    assert spans[0].resource == 'FLUSHALL'
 
     long_cmd = "mget %s" % " ".join(map(str, range(1000)))
     us = r.execute_command(long_cmd)
 
     spans = pin.tracer.writer.pop()
-    eq_(len(spans), 1)
+    assert len(spans) == 1
     span = spans[0]
-    eq_(span.service, 'redis')
-    eq_(span.name, 'redis.command')
-    eq_(span.span_type, 'redis')
-    eq_(span.error, 0)
+    assert span.service == 'redis'
+    assert span.name == 'redis.command'
+    assert span.span_type == 'redis'
+    assert span.error == 0
     meta = {
         'out.host': u'localhost',
         'out.port': str(REDIS_CONFIG['port']),
         'out.redis_db': u'0',
     }
     for k, v in meta.items():
-        eq_(span.get_tag(k), v)
+        assert span.get_tag(k) == v
 
     assert span.get_tag('redis.raw_command').startswith(u'mget 0 1 2 3')
     assert span.get_tag('redis.raw_command').endswith(u'...')

tests/commands/ddtrace_run_no_debug.py

@@ -1,7 +1,5 @@
 from ddtrace import tracer
 
-from nose.tools import ok_
-
 if __name__ == '__main__':
-    ok_(not tracer.debug_logging)
+    assert not tracer.debug_logging
     print("Test success")

tests/commands/ddtrace_run_patched_modules.py

@@ -1,7 +1,5 @@
 from ddtrace import monkey
 
-from nose.tools import ok_
-
 if __name__ == '__main__':
-    ok_('redis' in monkey.get_patched_modules())
+    assert 'redis' in monkey.get_patched_modules()
     print("Test success")

tests/commands/ddtrace_run_priority_sampling.py

@@ -1,7 +1,5 @@
 from ddtrace import tracer
 
-from nose.tools import ok_
-
 if __name__ == '__main__':
-    ok_(tracer.priority_sampler is not None)
+    assert tracer.priority_sampler is not None
     print("Test success")

tests/commands/ddtrace_run_service.py

@@ -1,7 +1,5 @@
 import os
 
-from nose.tools import eq_
-
 if __name__ == '__main__':
-    eq_(os.environ['DATADOG_SERVICE_NAME'], 'my_test_service')
+    assert os.environ['DATADOG_SERVICE_NAME'] == 'my_test_service'
     print('Test success')

tests/commands/ddtrace_run_sitecustomize.py

@@ -1,16 +1,15 @@
 import sys
-from nose.tools import ok_
 
 
 if __name__ == '__main__':
     # detect if `-S` is used
     suppress = len(sys.argv) == 2 and sys.argv[1] == '-S'
     if suppress:
-        ok_('sitecustomize' not in sys.modules)
+        assert 'sitecustomize' not in sys.modules
     else:
-        ok_('sitecustomize' in sys.modules)
+        assert 'sitecustomize' in sys.modules
 
     # ensure the right `sitecustomize` will be imported
     import sitecustomize
-    ok_(sitecustomize.CORRECT_IMPORT)
+    assert sitecustomize.CORRECT_IMPORT
     print('Test success')

tests/commands/test_runner.py

@@ -4,8 +4,6 @@
 import subprocess
 import unittest
 
-from nose.tools import ok_
-
 from ..util import inject_sitecustomize
 
 
@@ -189,7 +187,7 @@ def test_sitecustomize_without_ddtrace_run_command(self):
         )
         # `out` contains the `loaded` status of the module
         result = out[:-1] == b'True'
-        ok_(result)
+        assert result
 
     def test_sitecustomize_run(self):
         # [Regression test]: ensure users `sitecustomize.py` is properly loaded,

tests/contrib/aiobotocore/py35/test.py

@@ -1,7 +1,6 @@
 # flake8: noqa
 # DEV: Skip linting, we lint with Python 2, we'll get SyntaxErrors from `async`
 import aiobotocore
-from nose.tools import eq_
 
 from ddtrace.contrib.aiobotocore.patch import patch, unpatch
 
@@ -42,32 +41,32 @@ async def test_response_context_manager(self):
         pre_08 = int(version[0]) == 0 and int(version[1]) < 8
         # Version 0.8+ generates only one span for reading an object.
         if pre_08:
-            eq_(len(traces), 2)
-            eq_(len(traces[0]), 1)
-            eq_(len(traces[1]), 1)
+            assert len(traces) == 2
+            assert len(traces[0]) == 1
+            assert len(traces[1]) == 1
 
             span = traces[0][0]
-            eq_(span.get_tag('aws.operation'), 'GetObject')
-            eq_(span.get_tag('http.status_code'), '200')
-            eq_(span.service, 'aws.s3')
-            eq_(span.resource, 's3.getobject')
+            assert span.get_tag('aws.operation') == 'GetObject'
+            assert span.get_tag('http.status_code') == '200'
+            assert span.service == 'aws.s3'
+            assert span.resource == 's3.getobject'
 
             read_span = traces[1][0]
-            eq_(read_span.get_tag('aws.operation'), 'GetObject')
-            eq_(read_span.get_tag('http.status_code'), '200')
-            eq_(read_span.service, 'aws.s3')
-            eq_(read_span.resource, 's3.getobject')
-            eq_(read_span.name, 's3.command.read')
+            assert read_span.get_tag('aws.operation') == 'GetObject'
+            assert read_span.get_tag('http.status_code') == '200'
+            assert read_span.service == 'aws.s3'
+            assert read_span.resource == 's3.getobject'
+            assert read_span.name == 's3.command.read'
             # enforce parenting
-            eq_(read_span.parent_id, span.span_id)
-            eq_(read_span.trace_id, span.trace_id)
+            assert read_span.parent_id == span.span_id
+            assert read_span.trace_id == span.trace_id
         else:
-            eq_(len(traces[0]), 1)
-            eq_(len(traces[0]), 1)
+            assert len(traces[0]) == 1
+            assert len(traces[0]) == 1
 
             span = traces[0][0]
-            eq_(span.get_tag('aws.operation'), 'GetObject')
-            eq_(span.get_tag('http.status_code'), '200')
-            eq_(span.service, 'aws.s3')
-            eq_(span.resource, 's3.getobject')
-            eq_(span.name, 's3.command')
+            assert span.get_tag('aws.operation') == 'GetObject'
+            assert span.get_tag('http.status_code') == '200'
+            assert span.service == 'aws.s3'
+            assert span.resource == 's3.getobject'
+            assert span.name == 's3.command'