Skip to content

Commit 0a17f60

Browse files
committed
feat: Rename SparseOptions to Options.
BREAKING CHANGE: Now that all the other options types are named after Configuration, we can rename SparseOptions to just Options.
1 parent 72e7b5a commit 0a17f60

25 files changed

+90
-90
lines changed

packages/css-blocks/src/BlockCompiler/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
} from "../BlockSyntax";
1111
import { StyleAnalysis } from "../TemplateAnalysis/StyleAnalysis";
1212
import { normalizeOptions } from "../normalizeOptions";
13-
import { ResolvedConfiguration, SparseOptions } from "../options";
13+
import { Options, ResolvedConfiguration } from "../options";
1414

1515
import { ConflictResolver } from "./ConflictResolver";
1616
/**
@@ -21,7 +21,7 @@ export class BlockCompiler {
2121
private config: ResolvedConfiguration;
2222
private postcss: typeof postcss;
2323

24-
constructor(postcssImpl: typeof postcss, opts?: SparseOptions) {
24+
constructor(postcssImpl: typeof postcss, opts?: Options) {
2525
this.config = normalizeOptions(opts);
2626
this.postcss = postcssImpl;
2727
}

packages/css-blocks/src/BlockParser/BlockFactory.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { RawSourceMap } from "source-map";
77
import { Block } from "../Block";
88
import { FileIdentifier, ImportedFile, Importer } from "../importing";
99
import { normalizeOptions } from "../normalizeOptions";
10-
import { ResolvedConfiguration, SparseOptions } from "../options";
10+
import { Options, ResolvedConfiguration } from "../options";
1111
import { PromiseQueue } from "../util/PromiseQueue";
1212

1313
import { BlockParser, ParsedSource } from "./BlockParser";
@@ -46,7 +46,7 @@ export class BlockFactory {
4646
private paths: ObjectDictionary<string>;
4747
private preprocessQueue: PromiseQueue<PreprocessJob, ProcessedFile>;
4848

49-
constructor(options: SparseOptions, postcssImpl = postcss) {
49+
constructor(options: Options, postcssImpl = postcss) {
5050
this.postcssImpl = postcssImpl;
5151
this.configuration = normalizeOptions(options);
5252
this.importer = this.configuration.importer;

packages/css-blocks/src/BlockParser/BlockParser.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Block } from "../Block";
44
import * as errors from "../errors";
55
import { FileIdentifier } from "../importing";
66
import { normalizeOptions } from "../normalizeOptions";
7-
import { ResolvedConfiguration, SparseOptions } from "../options";
7+
import { Options, ResolvedConfiguration } from "../options";
88

99
import { assertForeignGlobalAttribute } from "./features/assert-foreign-global-attribute";
1010
import { constructBlock } from "./features/construct-block";
@@ -35,7 +35,7 @@ export class BlockParser {
3535
private config: ResolvedConfiguration;
3636
private factory: BlockFactory;
3737

38-
constructor(opts: SparseOptions, factory: BlockFactory) {
38+
constructor(opts: Options, factory: BlockFactory) {
3939
this.config = normalizeOptions(opts);
4040
this.factory = factory;
4141
}

packages/css-blocks/src/Plugin.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { BlockCompiler } from "./BlockCompiler";
44
import { BlockFactory } from "./BlockParser";
55
import * as errors from "./errors";
66
import { normalizeOptions } from "./normalizeOptions";
7-
import { ResolvedConfiguration, SparseOptions } from "./options";
8-
export { SparseOptions } from "./options";
7+
import { Options, ResolvedConfiguration } from "./options";
8+
export { Options } from "./options";
99

1010
/**
1111
* CSS Blocks PostCSS plugin.
@@ -18,7 +18,7 @@ export class Plugin {
1818
* @param postcssImpl PostCSS instance to use
1919
* @param opts Optional plugin config options
2020
*/
21-
constructor(postcssImpl: typeof postcss, opts?: SparseOptions) {
21+
constructor(postcssImpl: typeof postcss, opts?: Options) {
2222
this.config = normalizeOptions(opts);
2323
this.postcss = postcssImpl;
2424
}

packages/css-blocks/src/normalizeOptions.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {
2+
Options,
23
ResolvedConfiguration,
3-
SparseOptions,
44
} from "./options";
55

66
import { OutputMode } from "./OutputMode";
@@ -30,7 +30,7 @@ const DEFAULTS: ResolvedConfiguration = {
3030
class OptionsReader implements ResolvedConfiguration {
3131
private _opts: ResolvedConfiguration;
3232

33-
constructor(options: SparseOptions = {}, defaults: SparseOptions = {}) {
33+
constructor(options: Options = {}, defaults: Options = {}) {
3434
this._opts = {...DEFAULTS};
3535
for (let k of Object.keys(defaults)) {
3636
if (defaults[k] !== undefined) {
@@ -66,7 +66,7 @@ class OptionsReader implements ResolvedConfiguration {
6666
}
6767
}
6868

69-
export function normalizeOptions(options: SparseOptions | undefined, defaults?: SparseOptions): ResolvedConfiguration {
69+
export function normalizeOptions(options: Options | undefined, defaults?: Options): ResolvedConfiguration {
7070
if (options instanceof OptionsReader) {
7171
return options;
7272
} else {

packages/css-blocks/src/options.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export interface Configuration {
2727
/**
2828
* Valid user-provided options for the CSS Blocks plugin.
2929
*/
30-
export type SparseOptions = Partial<Readonly<Configuration>>;
30+
export type Options = Partial<Readonly<Configuration>>;
3131

3232
/**
3333
* Options that can/will be read but not changed. Default

packages/css-blocks/test/importing-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ import {
1313
normalizeOptions,
1414
} from "../src/normalizeOptions";
1515
import {
16+
Options,
1617
ResolvedConfiguration,
17-
SparseOptions,
1818
} from "../src/options";
1919

2020
const FIXTURES = path.resolve(__dirname, "..", "..", "test", "fixtures");
2121
const FSI_FIXTURES = path.resolve(FIXTURES, "filesystemImporter");
2222
const ALIAS_FIXTURES = path.resolve(FIXTURES, "pathAliasImporter");
2323

24-
function getOptions(options?: SparseOptions): ResolvedConfiguration {
24+
function getOptions(options?: Options): ResolvedConfiguration {
2525
return normalizeOptions(options, {rootDir: path.join(FSI_FIXTURES)});
2626
}
2727

packages/css-blocks/test/opticss-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ import { TemplateAnalysis } from "../src/TemplateAnalysis";
2121
import { ElementAnalysis } from "../src/TemplateAnalysis/ElementAnalysis";
2222
import { StyleMapping } from "../src/TemplateRewriter/StyleMapping";
2323
import { normalizeOptions } from "../src/normalizeOptions";
24-
import { SparseOptions } from "../src/options";
24+
import { Options } from "../src/options";
2525

2626
type BlockAndRoot = [Block, postcss.Container];
2727

2828
type Analysis = TemplateAnalysis<"Opticss.Template">;
2929

3030
@suite("Optimization")
3131
export class TemplateAnalysisTests {
32-
private parseBlock(css: string, filename: string, opts?: SparseOptions, blockName = "optimized"): Promise<BlockAndRoot> {
32+
private parseBlock(css: string, filename: string, opts?: Options, blockName = "optimized"): Promise<BlockAndRoot> {
3333
let options = normalizeOptions(opts);
3434
let factory = new BlockFactory(options, postcss);
3535
let root = postcss.parse(css, {from: filename});

packages/css-blocks/test/query-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import * as postcss from "postcss";
55
import { Block } from "../src/Block";
66
import { BlockFactory } from "../src/BlockParser";
77
import { normalizeOptions } from "../src/normalizeOptions";
8-
import { SparseOptions } from "../src/options";
8+
import { Options } from "../src/options";
99
import { QueryKeySelector } from "../src/query";
1010

1111
type BlockAndRoot = [Block, postcss.Container];
1212

1313
@suite("Querying")
1414
export class KeyQueryTests {
15-
private parseBlock(css: string, filename: string, opts?: SparseOptions): Promise<BlockAndRoot> {
15+
private parseBlock(css: string, filename: string, opts?: Options): Promise<BlockAndRoot> {
1616
let options = normalizeOptions(opts);
1717
let factory = new BlockFactory(options, postcss);
1818
let root = postcss.parse(css, {from: filename});

packages/css-blocks/test/template-analysis-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { BlockFactory } from "../src/BlockParser";
99
import { ElementAnalysis, SerializedTemplateAnalysis, TemplateAnalysis } from "../src/TemplateAnalysis";
1010
import * as cssBlocks from "../src/errors";
1111
import { normalizeOptions } from "../src/normalizeOptions";
12-
import { SparseOptions } from "../src/options";
12+
import { Options } from "../src/options";
1313

1414
import { MockImportRegistry } from "./util/MockImportRegistry";
1515
import { assertParseError } from "./util/assertError";
@@ -20,7 +20,7 @@ type BlockAndRoot = [Block, postcss.Container];
2020

2121
@suite("Template Analysis")
2222
export class TemplateAnalysisTests {
23-
private parseBlock(css: string, filename: string, opts?: SparseOptions, blockName = "analysis"): Promise<BlockAndRoot> {
23+
private parseBlock(css: string, filename: string, opts?: Options, blockName = "analysis"): Promise<BlockAndRoot> {
2424
let options = normalizeOptions(opts);
2525
let factory = new BlockFactory(options, postcss);
2626
let root = postcss.parse(css, {from: filename});

packages/css-blocks/test/util/BEMProcessor.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import * as perfectionist from "perfectionist";
22
import * as postcss from "postcss";
33

44
import cssBlocks = require("../../src/cssBlocks");
5-
import { SparseOptions } from "../../src/options";
5+
import { Options } from "../../src/options";
66

77
export class BEMProcessor {
8-
process(filename: string, contents: string, cssBlocksOpts?: SparseOptions) {
8+
process(filename: string, contents: string, cssBlocksOpts?: Options) {
99
let processOpts = { from: filename };
1010
let cssBlocksProcessor = cssBlocks(postcss);
1111
return postcss([

packages/css-blocks/test/validations/attribute-group-validator-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { BlockFactory } from "../../src/BlockParser";
88
import { TemplateAnalysis } from "../../src/TemplateAnalysis";
99
import * as cssBlocks from "../../src/errors";
1010
import { normalizeOptions } from "../../src/normalizeOptions";
11-
import { SparseOptions } from "../../src/options";
11+
import { Options } from "../../src/options";
1212

1313
import { MockImportRegistry } from "./../util/MockImportRegistry";
1414
import { assertParseError } from "./../util/assertError";
@@ -17,7 +17,7 @@ type BlockAndRoot = [Block, postcss.Container];
1717

1818
@suite("Attribute Group Validator")
1919
export class TemplateAnalysisTests {
20-
private parseBlock(css: string, filename: string, opts?: SparseOptions, blockName = "analysis"): Promise<BlockAndRoot> {
20+
private parseBlock(css: string, filename: string, opts?: Options, blockName = "analysis"): Promise<BlockAndRoot> {
2121
let options = normalizeOptions(opts);
2222
let factory = new BlockFactory(options, postcss);
2323
let root = postcss.parse(css, { from: filename });

packages/css-blocks/test/validations/attribute-parent-validator-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { BlockFactory } from "../../src/BlockParser";
88
import { TemplateAnalysis } from "../../src/TemplateAnalysis";
99
import * as cssBlocks from "../../src/errors";
1010
import { normalizeOptions } from "../../src/normalizeOptions";
11-
import { SparseOptions } from "../../src/options";
11+
import { Options } from "../../src/options";
1212

1313
import { MockImportRegistry } from "./../util/MockImportRegistry";
1414
import { assertParseError } from "./../util/assertError";
@@ -17,7 +17,7 @@ type BlockAndRoot = [Block, postcss.Container];
1717

1818
@suite("State Parent Validator")
1919
export class TemplateAnalysisTests {
20-
private parseBlock(css: string, filename: string, opts?: SparseOptions, blockName = "analysis"): Promise<BlockAndRoot> {
20+
private parseBlock(css: string, filename: string, opts?: Options, blockName = "analysis"): Promise<BlockAndRoot> {
2121
let options = normalizeOptions(opts);
2222
let factory = new BlockFactory(options, postcss);
2323
let root = postcss.parse(css, { from: filename });

packages/css-blocks/test/validations/class-pairs-validator-test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ import { BlockFactory } from "../../src/BlockParser";
77
import { TemplateAnalysis } from "../../src/TemplateAnalysis";
88
import * as cssBlocks from "../../src/errors";
99
import { normalizeOptions } from "../../src/normalizeOptions";
10-
import { SparseOptions } from "../../src/options";
10+
import { Options } from "../../src/options";
1111
import { assertParseError } from "../util/assertError";
1212

1313
type BlockAndRoot = [Block, postcss.Container];
1414

1515
@suite("Class Pairs Validator")
1616
export class TemplateAnalysisTests {
17-
private parseBlock(css: string, filename: string, opts?: SparseOptions, blockName = "analysis"): Promise<BlockAndRoot> {
17+
private parseBlock(css: string, filename: string, opts?: Options, blockName = "analysis"): Promise<BlockAndRoot> {
1818
let options = normalizeOptions(opts);
1919
let factory = new BlockFactory(options, postcss);
2020
let root = postcss.parse(css, { from: filename });

0 commit comments

Comments
 (0)