fix: Apply CR suggestions

- Update isDefinitionUrlValid().
- Avoid object destructuring.

Co-authored-by: Chris Eppstein <[email protected]>

Author: timlindvall

packages/@css-blocks/core/src/PrecompiledDefinitions/compiled-comments.ts

@@ -31,12 +31,13 @@ export const REGEXP_COMMENT_FOOTER = /\/\*#css-blocks end\*\//m;
  * @returns True if valid given the above rules, false otherwise.
  */
 export function isDefinitionUrlValid(urlOrPath: string): boolean {
-  // Try to parse as a URL first.
+  if (path.isAbsolute(urlOrPath)) {
+    return false;
+   }
   const parsedUrl = url.parse(urlOrPath);
   if (parsedUrl.protocol) {
     return parsedUrl.protocol === "data:";
+  } else {
+    return true;
   }
-
-  // If we can't parse as a URL with a protocol, it's a path.
-  return !path.isAbsolute(urlOrPath);
 }

packages/@css-blocks/core/src/importing/BaseImporter.ts

@@ -74,13 +74,13 @@ export abstract class BaseImporter implements Importer {
 
     // Determine start/end indexes based on the regexp results above.
     const [headerFullMatch, blockIdFromComment] = headerRegexpResult;
-    const { index: headerStartIndex } = headerRegexpResult;
+    const headerStartIndex = headerRegexpResult.index;
     if (!headerStartIndex) {
       throw new Error("Unable to determine start location of regexp result.");
     }
     const headerEndIndex = headerStartIndex + headerFullMatch.length;
     const [footerFullMatch] = footerRegexpResult;
-    const { index: footerStartIndex } = footerRegexpResult;
+    const footerStartIndex = footerRegexpResult.index;
     if (!footerStartIndex) {
       throw new Error("Unable to determine start location of regexp result.");
     }