fix: The analysis array gets added to while processing it so we have to monitor the array until its length doesn't change.

Author: chriseppstein

packages/jsx-analyzer/src/index.ts

@@ -146,7 +146,7 @@ export function parse(filename: string, data: string, factory: BlockFactory, opt
 
   return Promise.resolve().then(() => {
     return parseWith(template, metaAnalysis, factory, resolvedOpts).then(analysis => {
-      return Promise.all(metaAnalysis.analysisPromises).then((analyses) => {
+      return resolveAllRecursively(metaAnalysis.analysisPromises).then((analyses) => {
         for (let analysis of (new Set(analyses))) {
           traverse(analysis.template.ast, analyzer(analysis));
           metaAnalysis.addAnalysis(analysis);
@@ -160,6 +160,25 @@ export function parse(filename: string, data: string, factory: BlockFactory, opt
   });
 }
 
+function resolveAllRecursively<T>(promiseArray: Array<Promise<T>>): Promise<Array<T>> {
+  return new Promise<Array<T>>((resolve, reject) => {
+    let currentLength = promiseArray.length;
+    let waitAgain = (promise: Promise<Array<T>>): void => {
+      promise.then((values) => {
+        if (promiseArray.length === currentLength) {
+          resolve(values);
+        } else {
+          currentLength = promiseArray.length;
+          waitAgain(Promise.all(promiseArray));
+        }
+      }, (error) => {
+        reject(error);
+      });
+    };
+    waitAgain(Promise.all(promiseArray));
+  });
+}
+
 /**
  * Provided a file path, return a promise for the fully parsed analytics object.
  * // TODO: Make streaming?

packages/jsx-analyzer/src/transformer/webpackLoader.ts

@@ -53,7 +53,8 @@ export default function CSSBlocksWebpackAdapter(this: any, source: any, map: any
 
   .then((mappings: StyleMapping[]) => {
     mappings.forEach((mapping: StyleMapping) => {
-      let styleMapping: StyleMapping | undefined = mapping.analyses && mapping.analyses.find(a => a.template.identifier === path ) && mapping;
+      // When an css or analysis error happens the mapping seems to be undefined and generates a confusing error.
+      let styleMapping: StyleMapping | undefined = mapping && mapping.analyses && mapping.analyses.find(a => a.template.identifier === path ) && mapping;
       if ( !styleMapping ) {
         return;
       }