Skip to content

Upgrade @css-blocks/ember-cli to use the ember addon blueprint. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amiller-gh opened this issue Apr 24, 2018 · 2 comments
Closed

Upgrade @css-blocks/ember-cli to use the ember addon blueprint. #124

amiller-gh opened this issue Apr 24, 2018 · 2 comments
Labels
@css-blocks/ember-cli Issue with the CSS Blocks ember-cli integration

Comments

@amiller-gh
Copy link
Contributor

Because CSS Blocks does not work with full Ember apps quite yet, we could not use the ember addon blueprint to deliver our ember-cli integration and still have our tests pass.

While we work on finishing full Ember integration, we should have a working branch with a fully fledged ember addon at src/packages/@css-blocks/ember-cli.

Once tests pass on this branch (aka: integration is finished and Blocks works in the dummy app) we can merge it in to master.

@amiller-gh amiller-gh added @css-blocks/ember-cli Issue with the CSS Blocks ember-cli integration help wanted labels Apr 24, 2018
@Turbo87
Copy link

Turbo87 commented Apr 25, 2018

@amiller-gh I'm wondering if we should split glimmer and ember support into seperate packages for now, e.g. @css-blocks/glimmer-css-blocks and @css-blocks/ember-css-blocks. we could still share some of the internals but since the integration will likely be a little different it might make sense to keep complexity low for now by not trying to combine support for both pipelines yet.

@amiller-gh
Copy link
Contributor Author

amiller-gh commented May 23, 2018

PSA: Continued discussion is happening in ✨this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@css-blocks/ember-cli Issue with the CSS Blocks ember-cli integration
Projects
None yet
Development

No branches or pull requests

2 participants