ima: Fix a potential NULL pointer access in ima_restore_measurement_list

In restore_template_fmt, when kstrdup fails, a non-NULL value will still be
returned, which causes a NULL pointer access in template_desc_init_fields.

Fixes: c7d0936 ("ima: support restoring multiple template formats")
Cc: [email protected]
Co-developed-by: Jiaming Li <[email protected]>
Signed-off-by: Jiaming Li <[email protected]>
Signed-off-by: Huaxin Lu <[email protected]>
Reviewed-by: Stefan Berger <[email protected]>
Signed-off-by: Mimi Zohar <[email protected]>

Author: Huaxin Lu

security/integrity/ima/ima_template.c

@@ -340,8 +340,11 @@ static struct ima_template_desc *restore_template_fmt(char *template_name)
 
 	template_desc->name = "";
 	template_desc->fmt = kstrdup(template_name, GFP_KERNEL);
-	if (!template_desc->fmt)
+	if (!template_desc->fmt) {
+		kfree(template_desc);
+		template_desc = NULL;
 		goto out;
+	}
 
 	spin_lock(&template_list);
 	list_add_tail_rcu(&template_desc->list, &defined_templates);