Skip to content

Commit d41da3e

Browse files
Boris BREZILLONNicolas Ferre
Boris BREZILLON
authored and
Nicolas Ferre
committed
rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource
Replace devm_ioremap calls by devm_ioremap_resource which already check resource consistency (resource != NULL) and print an error in case of failure. Signed-off-by: Boris BREZILLON <[email protected]> Acked-by: Alexandre Belloni <[email protected]> Acked-by: Johan Hovold <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Signed-off-by: Nicolas Ferre <[email protected]>
1 parent 272f1df commit d41da3e

File tree

1 file changed

+10
-19
lines changed

1 file changed

+10
-19
lines changed

drivers/rtc/rtc-at91sam9.c

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -306,18 +306,11 @@ static const struct rtc_class_ops at91_rtc_ops = {
306306
*/
307307
static int at91_rtc_probe(struct platform_device *pdev)
308308
{
309-
struct resource *r, *r_gpbr;
309+
struct resource *r;
310310
struct sam9_rtc *rtc;
311311
int ret, irq;
312312
u32 mr;
313313

314-
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
315-
r_gpbr = platform_get_resource(pdev, IORESOURCE_MEM, 1);
316-
if (!r || !r_gpbr) {
317-
dev_err(&pdev->dev, "need 2 ressources\n");
318-
return -ENODEV;
319-
}
320-
321314
irq = platform_get_irq(pdev, 0);
322315
if (irq < 0) {
323316
dev_err(&pdev->dev, "failed to get interrupt resource\n");
@@ -335,18 +328,16 @@ static int at91_rtc_probe(struct platform_device *pdev)
335328
device_init_wakeup(&pdev->dev, 1);
336329

337330
platform_set_drvdata(pdev, rtc);
338-
rtc->rtt = devm_ioremap(&pdev->dev, r->start, resource_size(r));
339-
if (!rtc->rtt) {
340-
dev_err(&pdev->dev, "failed to map registers, aborting.\n");
341-
return -ENOMEM;
342-
}
343331

344-
rtc->gpbr = devm_ioremap(&pdev->dev, r_gpbr->start,
345-
resource_size(r_gpbr));
346-
if (!rtc->gpbr) {
347-
dev_err(&pdev->dev, "failed to map gpbr registers, aborting.\n");
348-
return -ENOMEM;
349-
}
332+
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
333+
rtc->rtt = devm_ioremap_resource(&pdev->dev, r);
334+
if (IS_ERR(rtc->rtt))
335+
return PTR_ERR(rtc->rtt);
336+
337+
r = platform_get_resource(pdev, IORESOURCE_MEM, 1);
338+
rtc->gpbr = devm_ioremap_resource(&pdev->dev, r);
339+
if (IS_ERR(rtc->gpbr))
340+
return PTR_ERR(rtc->rtt);
350341

351342
mr = rtt_readl(rtc, MR);
352343

0 commit comments

Comments
 (0)