[CIR][NFC] Use free function form of cast isa and dyn_cast

Author: seven-mile

clang/lib/CIR/CodeGen/CIRGenBuilder.h

@@ -799,7 +799,7 @@ class CIRGenBuilderTy : public CIRBaseBuilderTy {
   mlir::cir::VecShuffleOp
   createVecShuffle(mlir::Location loc, mlir::Value vec1, mlir::Value vec2,
                    llvm::ArrayRef<mlir::Attribute> maskAttrs) {
-    auto vecType = vec1.getType().cast<mlir::cir::VectorType>();
+    auto vecType = mlir::cast<mlir::cir::VectorType>(vec1.getType());
     auto resultTy = mlir::cir::VectorType::get(
         getContext(), vecType.getEltType(), maskAttrs.size());
     return CIRBaseBuilderTy::create<mlir::cir::VecShuffleOp>(

clang/lib/CIR/CodeGen/CIRGenExpr.cpp

@@ -662,7 +662,7 @@ RValue CIRGenFunction::buildLoadOfLValue(LValue LV, SourceLocation Loc) {
 
 int64_t CIRGenFunction::getAccessedFieldNo(unsigned int idx,
                                            const mlir::ArrayAttr elts) {
-  auto elt = elts.cast<mlir::ArrayAttr>()[idx].dyn_cast<mlir::IntegerAttr>();
+  auto elt = mlir::dyn_cast<mlir::IntegerAttr>(elts[idx]);
   assert(elt && "The indices should be integer attributes");
   return elt.getInt();
 }
@@ -675,7 +675,7 @@ RValue CIRGenFunction::buildLoadOfExtVectorElementLValue(LValue LV) {
 
   // HLSL allows treating scalars as one-element vectors. Converting the scalar
   // IR value to a vector here allows the rest of codegen to behave as normal.
-  if (getLangOpts().HLSL && !Vec.getType().isa<mlir::cir::VectorType>()) {
+  if (getLangOpts().HLSL && !mlir::isa<mlir::cir::VectorType>(Vec.getType())) {
     llvm_unreachable("HLSL NYI");
   }
 
@@ -728,7 +728,7 @@ void CIRGenFunction::buildStoreThroughExtVectorComponentLValue(RValue Src,
   // To support this we need to handle the case where the destination address is
   // a scalar.
   Address DstAddr = Dst.getExtVectorAddress();
-  if (!DstAddr.getElementType().isa<mlir::cir::VectorType>()) {
+  if (!mlir::isa<mlir::cir::VectorType>(DstAddr.getElementType())) {
     llvm_unreachable("HLSL NYI");
   }
 

clang/lib/CIR/CodeGen/CIRGenValue.h

@@ -328,7 +328,7 @@ class LValue {
   }
   mlir::ArrayAttr getExtVectorElts() const {
     assert(isExtVectorElt());
-    return VectorElts.cast<mlir::ArrayAttr>();
+    return mlir::cast<mlir::ArrayAttr>(VectorElts);
   }
 
   static LValue MakeVectorElt(Address vecAddress, mlir::Value Index,