Skip to content

Commit e6a5e49

Browse files
gitoleglanza
authored andcommitted
Revert "[mlir][llvm] Fixes CallOp builder for the case of indirect call"
This reverts commit bbaa147.
1 parent 0694c47 commit e6a5e49

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,16 +1025,8 @@ void CallOp::build(OpBuilder &builder, OperationState &state, TypeRange results,
10251025

10261026
void CallOp::build(OpBuilder &builder, OperationState &state, TypeRange results,
10271027
FlatSymbolRefAttr callee, ValueRange args) {
1028-
auto fargs = callee ? args : args.drop_front();
1028+
assert(callee && "expected non-null callee in direct call builder");
10291029
build(builder, state, results,
1030-
//
1031-
// TODO(ClangIR): This was a local change that is no longer valid during
1032-
// rebase
1033-
// TypeAttr::get(getLLVMFuncType(builder.getContext(), results, fargs)),
1034-
// callee, args, /*fastmathFlags=*/nullptr, /*branch_weights=*/nullptr,
1035-
// /*CConv=*/nullptr,
1036-
//
1037-
//
10381030
/*var_callee_type=*/nullptr, callee, args, /*fastmathFlags=*/nullptr,
10391031
/*branch_weights=*/nullptr,
10401032
/*CConv=*/nullptr, /*TailCallKind=*/nullptr,

0 commit comments

Comments
 (0)