Skip to content

Commit f7c508c

Browse files
authored
[CIR][NFC] Don't enforce deprecated API check on MSVC (#718)
Implements approach 2 in #703 (comment), as discussed in the community call. Signed-off-by: Julian Oppermann <[email protected]>
1 parent 89bf895 commit f7c508c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

clang/lib/CIR/CMakeLists.txt

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
include_directories(${LLVM_MAIN_SRC_DIR}/../mlir/include)
22
include_directories(${CMAKE_BINARY_DIR}/tools/mlir/include)
33

4-
# Report use of deprecated APIs as errors
5-
if (MSVC)
6-
add_compile_options("/we4996")
7-
else()
4+
# Report use of deprecated APIs as errors.
5+
# TODO: Consider adding `/we4996` for MSVC when upstream MLIR resolves
6+
# https://github.com/llvm/llvm-project/issues/65255.
7+
if (NOT MSVC)
88
add_compile_options("-Werror=deprecated-declarations")
9-
endif(MSVC)
9+
endif()
1010

1111
add_subdirectory(Dialect)
1212
add_subdirectory(CodeGen)

0 commit comments

Comments
 (0)