Skip to content

Commit 0bc54f7

Browse files
committed
AS, add FIXME
1 parent 27ea41c commit 0bc54f7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

llvm/lib/CodeGen/SanitizerBinaryMetadata.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
using namespace llvm;
2727

2828
namespace {
29+
// FIXME: This pass modifies Function metadata, which is not to be done in
30+
// MachineFunctionPass. It should probably be moved to a FunctionPass.
2931
class MachineSanitizerBinaryMetadataLegacy : public MachineFunctionPass {
3032
public:
3133
static char ID;
@@ -63,6 +65,7 @@ MachineSanitizerBinaryMetadataPass::run(MachineFunction &MF,
6365
MachineFunctionAnalysisManager &MFAM) {
6466
if (!MachineSanitizerBinaryMetadata().run(MF))
6567
return PreservedAnalyses::all();
68+
6669
return getMachineFunctionPassPreservedAnalyses();
6770
}
6871

0 commit comments

Comments
 (0)