Skip to content

Commit 24bf0e4

Browse files
authored
[libc++] Disable _LIBCPP_NODEBUG temporarily (#122393)
This should be reverted once the crash reported in #118710 has been analyzed.
1 parent 5d88a84 commit 24bf0e4

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

libcxx/include/__config

+3-1
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,9 @@ typedef __char32_t char32_t;
11701170
# define _LIBCPP_NOESCAPE
11711171
# endif
11721172

1173-
# define _LIBCPP_NODEBUG [[__gnu__::__nodebug__]]
1173+
// FIXME: Expand this to [[__gnu__::__nodebug__]] again once the testcase reported in
1174+
// https://github.com/llvm/llvm-project/pull/118710 has been analyzed
1175+
# define _LIBCPP_NODEBUG
11741176

11751177
# if __has_attribute(__standalone_debug__)
11761178
# define _LIBCPP_STANDALONE_DEBUG __attribute__((__standalone_debug__))

libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class LibcxxTestModule : public clang::tidy::ClangTidyModule {
2727
check_factories.registerCheck<libcpp::header_exportable_declarations>("libcpp-header-exportable-declarations");
2828
check_factories.registerCheck<libcpp::hide_from_abi>("libcpp-hide-from-abi");
2929
check_factories.registerCheck<libcpp::internal_ftm_use>("libcpp-internal-ftms");
30-
check_factories.registerCheck<libcpp::nodebug_on_aliases>("libcpp-nodebug-on-aliases");
30+
// check_factories.registerCheck<libcpp::nodebug_on_aliases>("libcpp-nodebug-on-aliases");
3131
check_factories.registerCheck<libcpp::proper_version_checks>("libcpp-cpp-version-check");
3232
check_factories.registerCheck<libcpp::robust_against_adl_check>("libcpp-robust-against-adl");
3333
check_factories.registerCheck<libcpp::uglify_attributes>("libcpp-uglify-attributes");

0 commit comments

Comments
 (0)