Skip to content

Commit 2844209

Browse files
committed
Move debug_frame comment
1 parent 4f683ee commit 2844209

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

llvm/include/llvm/CodeGen/FunctionLoweringInfo.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,11 +190,6 @@ class FunctionLoweringInfo {
190190

191191
/// The current call site index being processed, if any. 0 if none.
192192
unsigned CurCallSite = 0;
193-
// TODO: Ideally, what we'd like is to have a switch that allows emitting
194-
// synchronous (precise at call-sites only) CFA into .eh_frame. However,
195-
// even under this switch, we'd like .debug_frame to be precise when using
196-
// -g. At this moment, there's no way to specify that some CFI directives
197-
// go into .eh_frame only, while others go into .debug_frame only.
198193

199194
/// Collection of dbg.declare instructions handled after argument
200195
/// lowering and before ISel proper.

llvm/lib/CodeGen/MachineFunction.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,11 @@ void MachineFunction::print(raw_ostream &OS, const SlotIndexes *Indexes) const {
654654

655655
/// True if this function needs frame moves for debug or exceptions.
656656
bool MachineFunction::needsFrameMoves() const {
657+
// TODO: Ideally, what we'd like is to have a switch that allows emitting
658+
// synchronous (precise at call-sites only) CFA into .eh_frame. However, even
659+
// under this switch, we'd like .debug_frame to be precise when using -g. At
660+
// this moment, there's no way to specify that some CFI directives go into
661+
// .eh_frame only, while others go into .debug_frame only.
657662
return getMMI().hasDebugInfo() ||
658663
getTarget().Options.ForceDwarfFrameSection ||
659664
F.needsUnwindTableEntry();

0 commit comments

Comments
 (0)