Skip to content

Commit 46cf164

Browse files
Mention URL 'format' task (105257) for TODO's
1 parent 792deab commit 46cf164

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

libcxx/include/__stacktrace/basic_stacktrace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ _LIBCPP_EXPORTED_FROM_ABI inline ostream& operator<<(ostream& __os, const basic_
275275
// (19.6.5)
276276
// Formatting support [stacktrace.format]
277277

278-
// TODO(stacktrace23): needs `formatter`
278+
// TODO: stacktrace formatter: https://github.com/llvm/llvm-project/issues/105257
279279
template <class _Allocator>
280280
struct _LIBCPP_EXPORTED_FROM_ABI formatter<basic_stacktrace<_Allocator>>;
281281

libcxx/include/__stacktrace/stacktrace_entry.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ _LIBCPP_EXPORTED_FROM_ABI ostream& operator<<(ostream& __os, const stacktrace_en
9999
// (19.6.5)
100100
// Formatting support [stacktrace.format]
101101

102-
// TODO(stacktrace23): needs `formatter`
102+
// TODO: stacktrace formatter: https://github.com/llvm/llvm-project/issues/105257
103103
template <>
104104
struct _LIBCPP_EXPORTED_FROM_ABI formatter<stacktrace_entry>;
105105

libcxx/src/stacktrace/stacktrace.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ _LIBCPP_NO_TAIL_CALLS _LIBCPP_NOINLINE void context::do_stacktrace(size_t skip,
146146
gauntlet below should result in one of each of the above functions: (1) collector, (2) mod_ident, (3) resolver, (4)
147147
symbolizer. If any are missing or duplicated that is still fine; we work with zero or all the available utilities.
148148
149-
All these classes do their best to provide any of the requested fields they can: (symbol, filename, source line),
149+
All these classes do their best to provide any of the requested fields they can: symbol, filename, source line,
150150
substituting if needed with something reasonable. For example, if the source filename and line are not available
151151
then we will at least report that the address and symbol are in the module `foo.exe`.
152152

libcxx/test/std/diagnostics/stacktrace/format/formatter_basic_stacktrace.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ int main(int, char**) {
2525
output iterator of the context.
2626
*/
2727

28-
// TODO(stacktrace23): needs `formatter`
28+
// TODO: stacktrace formatter: https://github.com/llvm/llvm-project/issues/105257
2929

3030
return 0;
3131
}

libcxx/test/std/diagnostics/stacktrace/format/formatter_stacktrace_entry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ int main(int, char**) {
3131
of the context with additional padding and adjustments as specified by the format specifiers.
3232
*/
3333

34-
// TODO(stacktrace23): needs `formatter`
34+
// TODO: stacktrace formatter: https://github.com/llvm/llvm-project/issues/105257
3535

3636
return 0;
3737
}

0 commit comments

Comments
 (0)