Skip to content

Commit 4751f47

Browse files
[mlir][Transforms] Dialect conversion: Turn LLVM_DEPRECATED into comments (#122073)
Some functions of the deprecated 1:N dialect conversion were marked as `LLVM_DEPRECATED`. This caused compilation warnings because there are still test cases of the 1:N dialect conversion framework. (These test cases will be deleted at the same time when the 1:N driver is deleted.)
1 parent f993a8b commit 4751f47

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

mlir/include/mlir/Dialect/SCF/Transforms/Patterns.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ void populateSCFStructuralTypeConversionTarget(
6868
/// applyPartialOneToNConversion.
6969
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
7070
/// 1:N support has been added to the regular dialect conversion driver.
71-
LLVM_DEPRECATED("Use populateSCFStructuralTypeConversions() instead",
72-
"populateSCFStructuralTypeConversions")
71+
/// Use populateSCFStructuralTypeConversions() instead.
7372
void populateSCFStructuralOneToNTypeConversions(
7473
const TypeConverter &typeConverter, RewritePatternSet &patterns);
7574

mlir/include/mlir/Transforms/OneToNTypeConversion.h

+3-8
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ class OneToNPatternRewriter : public PatternRewriter {
123123
/// (i.e., the converted types must be the same as the types of the new
124124
/// values).
125125
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
126-
/// 1:N support has been added to the regular dialect conversion driver.
127-
LLVM_DEPRECATED("Use replaceOpWithMultiple() instead",
128-
"replaceOpWithMultiple")
126+
/// Use replaceOpWithMultiple() instead.
129127
void replaceOp(Operation *op, ValueRange newValues,
130128
const OneToNTypeMapping &resultMapping);
131129
using PatternRewriter::replaceOp;
@@ -260,8 +258,7 @@ class OneToNOpConversionPattern : public OneToNConversionPattern {
260258
/// only "partial").
261259
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
262260
/// 1:N support has been added to the regular dialect conversion driver.
263-
LLVM_DEPRECATED("Use applyPartialConversion() instead",
264-
"applyPartialConversion")
261+
/// Use applyPartialConversion() instead.
265262
LogicalResult
266263
applyPartialOneToNConversion(Operation *op, TypeConverter &typeConverter,
267264
const FrozenRewritePatternSet &patterns);
@@ -272,9 +269,7 @@ applyPartialOneToNConversion(Operation *op, TypeConverter &typeConverter,
272269
/// used with the 1:N dialect conversion.
273270
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
274271
/// 1:N support has been added to the regular dialect conversion driver.
275-
LLVM_DEPRECATED(
276-
"Use populateFunctionOpInterfaceTypeConversionPattern() instead",
277-
"populateFunctionOpInterfaceTypeConversionPattern")
272+
/// Use populateFunctionOpInterfaceTypeConversionPattern() instead.
278273
void populateOneToNFunctionOpInterfaceTypeConversionPattern(
279274
StringRef functionLikeOpName, const TypeConverter &converter,
280275
RewritePatternSet &patterns);

0 commit comments

Comments
 (0)