Skip to content

Commit 4f5d866

Browse files
authored
[llvm-lit] Add REQUIRES: shell to BOLT permission test for lit internal shell (#103012)
This patch adds the `REQUIRES: shell` directive to the BOLT permission test to ensure it only runs in environments with a full-featured Unix-like shell. This change is necessary because the test relies on advanced shell capabilities that are not supported by lit's internal shell. **Reasoning:** The BOLT permission test uses features like running commands in the background with `&`, performing arithmetic operations, and handling special number formats (octal). These features require a more capable shell than what lit's internal shell provides. Without a proper shell, the test could fail or behave unpredictably. This change is relevant for enabling the lit internal shell by default, as outlined in [[RFC] Enabling the Lit Internal Shell by Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)
1 parent e9f6dea commit 4f5d866

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bolt/test/permission.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# This test performs a logical AND operation on the results of the `stat -c %a
55
# %t.bolt` and `umask` commands (both results are displayed in octal), and
66
# checks whether the result is equal to 0.
7-
REQUIRES: system-linux
7+
REQUIRES: shell, system-linux
88

99
RUN: %clang %cflags %p/Inputs/hello.c -o %t -Wl,-q
1010
RUN: llvm-bolt %t -o %t.bolt

0 commit comments

Comments
 (0)