Fix MSVC "not all control paths return a value" warnings. NFC.

RKSimon · RKSimon · commit 539e076e1c99 · 2023-11-03T09:50:09.000Z
diff --git a/clang/include/clang/Basic/Linkage.h b/clang/include/clang/Basic/Linkage.h
@@ -100,6 +100,7 @@ inline bool isExternallyVisible(Linkage L) {
   case Linkage::External:
     return true;
   }
+  llvm_unreachable("Unhandled Linkage enum");
 }
 
 inline Linkage getFormalLinkage(Linkage L) {
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
@@ -1934,6 +1934,7 @@ bool NamedDecl::hasLinkage() const {
   case Linkage::External:
     return true;
   }
+  llvm_unreachable("Unhandled Linkage enum");
 }
 
 NamedDecl *NamedDecl::getUnderlyingDeclImpl() {

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ inline bool isExternallyVisible(Linkage L) {`
`100`	`100`	`case Linkage::External:`
`101`	`101`	`return true;`
`102`	`102`	`}`
	`103`	`+ llvm_unreachable("Unhandled Linkage enum");`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`inline Linkage getFormalLinkage(Linkage L) {`
Original file line number	Diff line number	Diff line change
`@@ -1934,6 +1934,7 @@ bool NamedDecl::hasLinkage() const {`
`1934`	`1934`	`case Linkage::External:`
`1935`	`1935`	`return true;`
`1936`	`1936`	`}`
	`1937`	`+ llvm_unreachable("Unhandled Linkage enum");`
`1937`	`1938`	`}`
`1938`	`1939`
`1939`	`1940`	`NamedDecl *NamedDecl::getUnderlyingDeclImpl() {`