Skip to content

Commit 59326c0

Browse files
committed
CodeGen: Remove -disable-debug-info-print cl::opt
This was first introduced way back in in 2010 by 6c74a87, and has little evidence of use. Only one test attempts to make use of this, but it's also redundant since it's also using strip to drop debug info anyway (and that also makes the test buggy, since it's intended to test with and without debug info). The other tests using it were only added to test the option after discovering it was untested and moved, in later commits.
1 parent 455990d commit 59326c0

File tree

4 files changed

+4
-79
lines changed

4 files changed

+4
-79
lines changed

llvm/lib/CodeGen/MachineModuleInfo.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@
3131
using namespace llvm;
3232
using namespace llvm::dwarf;
3333

34-
static cl::opt<bool>
35-
DisableDebugInfoPrinting("disable-debug-info-print", cl::Hidden,
36-
cl::desc("Disable debug info printing"));
37-
3834
// Out of line virtual method.
3935
MachineModuleInfoImpl::~MachineModuleInfoImpl() = default;
4036

@@ -224,8 +220,7 @@ bool MachineModuleInfoWrapperPass::doInitialization(Module &M) {
224220
Ctx.diagnose(
225221
DiagnosticInfoSrcMgr(SMD, M.getName(), IsInlineAsm, LocCookie));
226222
});
227-
MMI.DbgInfoAvailable = !DisableDebugInfoPrinting &&
228-
!M.debug_compile_units().empty();
223+
MMI.DbgInfoAvailable = !M.debug_compile_units().empty();
229224
return false;
230225
}
231226

@@ -250,7 +245,6 @@ MachineModuleAnalysis::run(Module &M, ModuleAnalysisManager &) {
250245
Ctx.diagnose(
251246
DiagnosticInfoSrcMgr(SMD, M.getName(), IsInlineAsm, LocCookie));
252247
});
253-
MMI.DbgInfoAvailable =
254-
!DisableDebugInfoPrinting && !M.debug_compile_units().empty();
248+
MMI.DbgInfoAvailable = !M.debug_compile_units().empty();
255249
return Result(MMI);
256250
}

llvm/test/CodeGen/Generic/disable-debug-info-print.ll

Lines changed: 0 additions & 50 deletions
This file was deleted.

llvm/test/CodeGen/X86/disable-debug-info-print-codeview.ll

Lines changed: 0 additions & 19 deletions
This file was deleted.

llvm/test/CodeGen/X86/frame-order.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
; RUN: llc -mtriple=x86_64-linux-gnueabi -disable-debug-info-print < %s | FileCheck %s
2-
; RUN: opt -passes=strip -S < %s | llc -mtriple=x86_64-linux-gnueabi -disable-debug-info-print | FileCheck %s
1+
; RUN: llc -mtriple=x86_64-linux-gnueabi < %s | FileCheck %s
2+
; RUN: opt -passes=strip -S < %s | llc -mtriple=x86_64-linux-gnueabi | FileCheck %s
33

44
; This test checks if the code is generated correctly with and without debug info.
55

0 commit comments

Comments
 (0)