Skip to content

Commit 6bec4fc

Browse files
authored
[libc] Fix flag parsing bugs. (#84706)
1 parent f786881 commit 6bec4fc

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

libc/cmake/modules/LLVMLibCCompileOptionRules.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ function(_get_compile_options_from_flags output_var)
22
set(compile_options "")
33

44
if(LIBC_TARGET_ARCHITECTURE_IS_RISCV64 OR(LIBC_CPU_FEATURES MATCHES "FMA"))
5-
check_flag(ADD_FMA_FLAG ${FMA_OPT_FLAG} ${flags})
5+
check_flag(ADD_FMA_FLAG ${FMA_OPT_FLAG} ${ARGN})
66
endif()
7-
check_flag(ADD_SSE4_2_FLAG ${ROUND_OPT_FLAG} ${flags})
8-
check_flag(ADD_EXPLICIT_SIMD_OPT_FLAG ${EXPLICIT_SIMD_OPT_FLAG} ${flags})
7+
check_flag(ADD_SSE4_2_FLAG ${ROUND_OPT_FLAG} ${ARGN})
8+
check_flag(ADD_EXPLICIT_SIMD_OPT_FLAG ${EXPLICIT_SIMD_OPT_FLAG} ${ARGN})
99

1010
if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
1111
if(ADD_FMA_FLAG)

libc/cmake/modules/LLVMLibCFlagRules.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ endfunction(get_fq_dep_list_without_flag)
131131

132132
# Check if a `flag` is set
133133
function(check_flag result flag_name)
134-
list(FIND ARGN ${flag_name}_FLAG has_flag)
134+
list(FIND ARGN ${flag_name} has_flag)
135135
if(${has_flag} LESS 0)
136-
list(FIND ARGN "${flag_name}_FLAG__ONLY" has_flag)
136+
list(FIND ARGN "${flag_name}__ONLY" has_flag)
137137
endif()
138138
if(${has_flag} GREATER -1)
139139
set(${result} TRUE PARENT_SCOPE)

0 commit comments

Comments
 (0)