Skip to content

Commit 95a204c

Browse files
authored
[CodeGenPassBuilder] Remove analysis registering interfaces (#81439)
PassBuilder already can do this.
1 parent 78f2eb8 commit 95a204c

File tree

1 file changed

+1
-66
lines changed

1 file changed

+1
-66
lines changed

llvm/include/llvm/Passes/CodeGenPassBuilder.h

Lines changed: 1 addition & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
/// \file
99
///
10-
/// Interfaces for registering analysis passes, producing common pass manager
11-
/// configurations, and parsing of pass pipelines.
10+
/// Interfaces for producing common pass manager configurations.
1211
///
1312
//===----------------------------------------------------------------------===//
1413

@@ -137,16 +136,6 @@ template <typename DerivedT> class CodeGenPassBuilder {
137136
raw_pwrite_stream &Out, raw_pwrite_stream *DwoOut,
138137
CodeGenFileType FileType) const;
139138

140-
void registerModuleAnalyses(ModuleAnalysisManager &) const;
141-
void registerFunctionAnalyses(FunctionAnalysisManager &) const;
142-
void registerMachineFunctionAnalyses(MachineFunctionAnalysisManager &) const;
143-
144-
void registerAnalyses(MachineFunctionAnalysisManager &MFAM) const {
145-
registerModuleAnalyses(*MFAM.MAM);
146-
registerFunctionAnalyses(*MFAM.FAM);
147-
registerMachineFunctionAnalyses(MFAM);
148-
}
149-
150139
PassInstrumentationCallbacks *getPassInstrumentationCallbacks() const {
151140
return PIC;
152141
}
@@ -239,14 +228,6 @@ template <typename DerivedT> class CodeGenPassBuilder {
239228
CGPassBuilderOption Opt;
240229
PassInstrumentationCallbacks *PIC;
241230

242-
/// Target override these hooks to parse target-specific analyses.
243-
void registerTargetAnalysis(ModuleAnalysisManager &) const {}
244-
void registerTargetAnalysis(FunctionAnalysisManager &) const {}
245-
void registerTargetAnalysis(MachineFunctionAnalysisManager &) const {}
246-
std::pair<StringRef, bool> getTargetPassNameFromLegacyName(StringRef) const {
247-
return {"", false};
248-
}
249-
250231
template <typename TMC> TMC &getTM() const { return static_cast<TMC &>(TM); }
251232
CodeGenOptLevel getOptLevel() const { return TM.getOptLevel(); }
252233

@@ -577,52 +558,6 @@ Error CodeGenPassBuilder<Derived>::verifyStartStop(
577558
return Error::success();
578559
}
579560

580-
static inline AAManager registerAAAnalyses() {
581-
AAManager AA;
582-
583-
// The order in which these are registered determines their priority when
584-
// being queried.
585-
586-
// Basic AliasAnalysis support.
587-
// Add TypeBasedAliasAnalysis before BasicAliasAnalysis so that
588-
// BasicAliasAnalysis wins if they disagree. This is intended to help
589-
// support "obvious" type-punning idioms.
590-
AA.registerFunctionAnalysis<TypeBasedAA>();
591-
AA.registerFunctionAnalysis<ScopedNoAliasAA>();
592-
AA.registerFunctionAnalysis<BasicAA>();
593-
594-
return AA;
595-
}
596-
597-
template <typename Derived>
598-
void CodeGenPassBuilder<Derived>::registerModuleAnalyses(
599-
ModuleAnalysisManager &MAM) const {
600-
#define MODULE_ANALYSIS(NAME, CREATE_PASS) \
601-
MAM.registerPass([&] { return CREATE_PASS; });
602-
#include "MachinePassRegistry.def"
603-
derived().registerTargetAnalysis(MAM);
604-
}
605-
606-
template <typename Derived>
607-
void CodeGenPassBuilder<Derived>::registerFunctionAnalyses(
608-
FunctionAnalysisManager &FAM) const {
609-
FAM.registerPass([this] { return registerAAAnalyses(); });
610-
611-
#define FUNCTION_ANALYSIS(NAME, CREATE_PASS) \
612-
FAM.registerPass([&] { return CREATE_PASS; });
613-
#include "MachinePassRegistry.def"
614-
derived().registerTargetAnalysis(FAM);
615-
}
616-
617-
template <typename Derived>
618-
void CodeGenPassBuilder<Derived>::registerMachineFunctionAnalyses(
619-
MachineFunctionAnalysisManager &MFAM) const {
620-
#define MACHINE_FUNCTION_ANALYSIS(NAME, CREATE_PASS) \
621-
MFAM.registerPass([&] { return CREATE_PASS; });
622-
#include "MachinePassRegistry.def"
623-
derived().registerTargetAnalysis(MFAM);
624-
}
625-
626561
template <typename Derived>
627562
void CodeGenPassBuilder<Derived>::addISelPasses(AddIRPass &addPass) const {
628563
derived().addGlobalMergePass(addPass);

0 commit comments

Comments
 (0)